github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-15 06:01:50 +00:00
Code Issues Projects Releases Wiki Activity

codegen: skip generation of informers and listers on resources with missing verbs

Browse Source
This commit is contained in:
Michal Fojtik
2017-08-04 11:50:43 +02:00
parent 68a722155b
commit cd23e5f1fc
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/kube-gen/cmd/informer-gen/generators/packages.go
View File

@@ -172,7 +172,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
var typesToGenerate []*types.Type var typesToGenerate []*types.Type
for _, t := range p.Types { for _, t := range p.Types {
tags := util.MustParseClientGenTags(t.SecondClosestCommentLines) tags := util.MustParseClientGenTags(t.SecondClosestCommentLines)
if !tags.GenerateClient || tags.NoVerbs { if !tags.GenerateClient || tags.NoVerbs || !tags.HasVerb("list") || !tags.HasVerb("watch") {
continue continue
} }
@@ -304,7 +304,8 @@ func groupPackage(basePackage string, groupVersions clientgentypes.GroupVersions
return generators return generators
}, },
FilterFunc: func(c *generator.Context, t *types.Type) bool { FilterFunc: func(c *generator.Context, t *types.Type) bool {
return util.MustParseClientGenTags(t.SecondClosestCommentLines).GenerateClient tags := util.MustParseClientGenTags(t.SecondClosestCommentLines)
return tags.GenerateClient && tags.HasVerb("list") && tags.HasVerb("watch")
}, },
} }
} }
@@ -344,7 +345,8 @@ func versionPackage(basePackage string, gv clientgentypes.GroupVersion, boilerpl
return generators return generators
}, },
FilterFunc: func(c *generator.Context, t *types.Type) bool { FilterFunc: func(c *generator.Context, t *types.Type) bool {
return util.MustParseClientGenTags(t.SecondClosestCommentLines).GenerateClient tags := util.MustParseClientGenTags(t.SecondClosestCommentLines)
return tags.GenerateClient && tags.HasVerb("list") && tags.HasVerb("watch")
}, },
} }
} }

9
staging/src/k8s.io/kube-gen/cmd/lister-gen/generators/lister.go
View File

@@ -117,11 +117,15 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
var typesToGenerate []*types.Type var typesToGenerate []*types.Type
for _, t := range p.Types { for _, t := range p.Types {
if !util.MustParseClientGenTags(t.SecondClosestCommentLines).GenerateClient { tags := util.MustParseClientGenTags(t.SecondClosestCommentLines)
if !tags.GenerateClient || !tags.HasVerb("list") || !tags.HasVerb("get") {
continue continue
} }
typesToGenerate = append(typesToGenerate, t) typesToGenerate = append(typesToGenerate, t)
} }
if len(typesToGenerate) == 0 {
continue
}
orderer := namer.Orderer{Namer: namer.NewPrivateNamer(0)} orderer := namer.Orderer{Namer: namer.NewPrivateNamer(0)}
typesToGenerate = orderer.OrderTypes(typesToGenerate) typesToGenerate = orderer.OrderTypes(typesToGenerate)
@@ -155,7 +159,8 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
return generators return generators
}, },
FilterFunc: func(c *generator.Context, t *types.Type) bool { FilterFunc: func(c *generator.Context, t *types.Type) bool {
return util.MustParseClientGenTags(t.SecondClosestCommentLines).GenerateClient tags := util.MustParseClientGenTags(t.SecondClosestCommentLines)
return tags.GenerateClient && tags.HasVerb("list") && tags.HasVerb("get")
}, },
}) })
} }