add a test case for HostnameOverride

modify
This commit is contained in:
yanghaichao12 2019-01-10 10:40:06 -05:00
parent 152226c557
commit cd5415f0ab

View File

@ -381,16 +381,24 @@ func TestProcessHostnameOverrideFlag(t *testing.T) {
name string name string
hostnameOverrideFlag string hostnameOverrideFlag string
expectedHostname string expectedHostname string
expectError bool
}{ }{
{ {
name: "Hostname from config file", name: "Hostname from config file",
hostnameOverrideFlag: "", hostnameOverrideFlag: "",
expectedHostname: "foo", expectedHostname: "foo",
expectError: false,
}, },
{ {
name: "Hostname from flag", name: "Hostname from flag",
hostnameOverrideFlag: " bar ", hostnameOverrideFlag: " bar ",
expectedHostname: "bar", expectedHostname: "bar",
expectError: false,
},
{
name: "Hostname is space",
hostnameOverrideFlag: " ",
expectError: true,
}, },
} }
for _, tc := range testCases { for _, tc := range testCases {
@ -403,9 +411,15 @@ func TestProcessHostnameOverrideFlag(t *testing.T) {
options.hostnameOverride = tc.hostnameOverrideFlag options.hostnameOverride = tc.hostnameOverrideFlag
err := options.processHostnameOverrideFlag() err := options.processHostnameOverrideFlag()
assert.NoError(t, err, "unexpected error %v", err) if tc.expectError {
if tc.expectedHostname != options.config.HostnameOverride { if err == nil {
t.Fatalf("expected hostname: %s, but got: %s", tc.expectedHostname, options.config.HostnameOverride) t.Fatalf("should error for this case %s", tc.name)
}
} else {
assert.NoError(t, err, "unexpected error %v", err)
if tc.expectedHostname != options.config.HostnameOverride {
t.Fatalf("expected hostname: %s, but got: %s", tc.expectedHostname, options.config.HostnameOverride)
}
} }
}) })
} }