github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #422 from claire921/use_splithostport

Browse Source 
pkg/proxy: use net.SplitHostPort instead of strings.Split
This commit is contained in:
brendandburns 2014-07-11 22:32:50 -07:00
commit cde7b5841b
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/proxy/roundrobbin.go
View File

@ -23,7 +23,6 @@ import (
"net" "net"
"reflect" "reflect"
"strconv" "strconv"
"strings"
"sync" "sync"
"github.com/GoogleCloudPlatform/kubernetes/pkg/api" "github.com/GoogleCloudPlatform/kubernetes/pkg/api"
@ -57,11 +56,11 @@ func (impl LoadBalancerRR) LoadBalance(service string, srcAddr net.Addr) (string
} }
func (impl LoadBalancerRR) IsValid(spec string) bool { func (impl LoadBalancerRR) IsValid(spec string) bool {
index := strings.Index(spec, ":") _, port, err := net.SplitHostPort(spec)
if index == -1 { if err != nil {
return false return false
} }
value, err := strconv.Atoi(spec[index+1:]) value, err := strconv.Atoi(port)
if err != nil { if err != nil {
return false return false
} }