github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #411 from nyaxt/lint_registry

Browse Source 
Fixes go lint errors on pkg/registry/controller_registry.go
This commit is contained in:
brendandburns 2014-07-11 21:41:58 -07:00
commit cdf75c57df
4 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/master/master.go
View File

@ -87,7 +87,7 @@ func (m *Master) init(cloud cloudprovider.Interface, podInfoGetter client.PodInf
s := scheduler.MakeFirstFitScheduler(m.podRegistry, m.random) s := scheduler.MakeFirstFitScheduler(m.podRegistry, m.random)
m.storage = map[string]apiserver.RESTStorage{ m.storage = map[string]apiserver.RESTStorage{
"pods": registry.MakePodRegistryStorage(m.podRegistry, podInfoGetter, s, m.minionRegistry, cloud, podCache), "pods": registry.MakePodRegistryStorage(m.podRegistry, podInfoGetter, s, m.minionRegistry, cloud, podCache),
"replicationControllers": registry.MakeControllerRegistryStorage(m.controllerRegistry, m.podRegistry), "replicationControllers": registry.NewControllerRegistryStorage(m.controllerRegistry, m.podRegistry),
"services": registry.MakeServiceRegistryStorage(m.serviceRegistry, cloud, m.minionRegistry), "services": registry.MakeServiceRegistryStorage(m.serviceRegistry, cloud, m.minionRegistry),
"minions": registry.MakeMinionRegistryStorage(m.minionRegistry), "minions": registry.MakeMinionRegistryStorage(m.minionRegistry),
} }

10
pkg/registry/controller_registry.go
View File

@ -26,7 +26,7 @@ import (
"github.com/GoogleCloudPlatform/kubernetes/pkg/labels" "github.com/GoogleCloudPlatform/kubernetes/pkg/labels"
) )
// Implementation of RESTStorage for the api server. // ControllerRegistryStorage is an implementation of RESTStorage for the api server.
type ControllerRegistryStorage struct { type ControllerRegistryStorage struct {
registry ControllerRegistry registry ControllerRegistry
podRegistry PodRegistry podRegistry PodRegistry
@ -34,7 +34,7 @@ type ControllerRegistryStorage struct {
pollPeriod time.Duration pollPeriod time.Duration
} }
func MakeControllerRegistryStorage(registry ControllerRegistry, podRegistry PodRegistry) apiserver.RESTStorage { func NewControllerRegistryStorage(registry ControllerRegistry, podRegistry PodRegistry) apiserver.RESTStorage {
return &ControllerRegistryStorage{ return &ControllerRegistryStorage{
registry: registry, registry: registry,
podRegistry: podRegistry, podRegistry: podRegistry,
@ -42,6 +42,7 @@ func MakeControllerRegistryStorage(registry ControllerRegistry, podRegistry PodR
} }
} }
// List obtains a list of ReplicationControllers that match selector.
func (storage *ControllerRegistryStorage) List(selector labels.Selector) (interface{}, error) { func (storage *ControllerRegistryStorage) List(selector labels.Selector) (interface{}, error) {
result := api.ReplicationControllerList{} result := api.ReplicationControllerList{}
controllers, err := storage.registry.ListControllers() controllers, err := storage.registry.ListControllers()
@ -55,6 +56,7 @@ func (storage *ControllerRegistryStorage) List(selector labels.Selector) (interf
return result, err return result, err
} }
// Get obtains the ReplicationController specified by its id.
func (storage *ControllerRegistryStorage) Get(id string) (interface{}, error) { func (storage *ControllerRegistryStorage) Get(id string) (interface{}, error) {
controller, err := storage.registry.GetController(id) controller, err := storage.registry.GetController(id)
if err != nil { if err != nil {
@ -63,18 +65,21 @@ func (storage *ControllerRegistryStorage) Get(id string) (interface{}, error) {
return controller, err return controller, err
} }
// Delete asynchronously deletes the ReplicationController specified by its id.
func (storage *ControllerRegistryStorage) Delete(id string) (<-chan interface{}, error) { func (storage *ControllerRegistryStorage) Delete(id string) (<-chan interface{}, error) {
return apiserver.MakeAsync(func() (interface{}, error) { return apiserver.MakeAsync(func() (interface{}, error) {
return api.Status{Status: api.StatusSuccess}, storage.registry.DeleteController(id) return api.Status{Status: api.StatusSuccess}, storage.registry.DeleteController(id)
}), nil }), nil
} }
// Extract deserializes user provided data into an api.ReplicationController.
func (storage *ControllerRegistryStorage) Extract(body []byte) (interface{}, error) { func (storage *ControllerRegistryStorage) Extract(body []byte) (interface{}, error) {
result := api.ReplicationController{} result := api.ReplicationController{}
err := api.DecodeInto(body, &result) err := api.DecodeInto(body, &result)
return result, err return result, err
} }
// Create registers a given new ReplicationController instance to storage.registry.
func (storage *ControllerRegistryStorage) Create(obj interface{}) (<-chan interface{}, error) { func (storage *ControllerRegistryStorage) Create(obj interface{}) (<-chan interface{}, error) {
controller, ok := obj.(api.ReplicationController) controller, ok := obj.(api.ReplicationController)
if !ok { if !ok {
@ -95,6 +100,7 @@ func (storage *ControllerRegistryStorage) Create(obj interface{}) (<-chan interf
}), nil }), nil
} }
// Update replaces a given ReplicationController instance with an existing instance in storage.registry.
func (storage *ControllerRegistryStorage) Update(obj interface{}) (<-chan interface{}, error) { func (storage *ControllerRegistryStorage) Update(obj interface{}) (<-chan interface{}, error) {
controller, ok := obj.(api.ReplicationController) controller, ok := obj.(api.ReplicationController)
if !ok { if !ok {

6
pkg/registry/interfaces.go
View File

@ -35,13 +35,13 @@ type PodRegistry interface {
DeletePod(podID string) error DeletePod(podID string) error
} }
// ControllerRegistry is an interface for things that know how to store Controllers. // ControllerRegistry is an interface for things that know how to store ReplicationControllers.
type ControllerRegistry interface { type ControllerRegistry interface {
ListControllers() ([]api.ReplicationController, error) ListControllers() ([]api.ReplicationController, error)
GetController(controllerId string) (*api.ReplicationController, error) GetController(controllerID string) (*api.ReplicationController, error)
CreateController(controller api.ReplicationController) error CreateController(controller api.ReplicationController) error
UpdateController(controller api.ReplicationController) error UpdateController(controller api.ReplicationController) error
DeleteController(controllerId string) error DeleteController(controllerID string) error
} }
// ServiceRegistry is an interface for things that know how to store services. // ServiceRegistry is an interface for things that know how to store services.

4
pkg/registry/memory_registry.go
View File

@ -93,8 +93,8 @@ func (registry *MemoryRegistry) CreateController(controller api.ReplicationContr
return nil return nil
} }
func (registry *MemoryRegistry) DeleteController(controllerId string) error { func (registry *MemoryRegistry) DeleteController(controllerID string) error {
delete(registry.controllerData, controllerId) delete(registry.controllerData, controllerID)
return nil return nil
} }