From ce013e288cdae0da6dca8f40203f65d4576c7c0c Mon Sep 17 00:00:00 2001 From: "Dr. Stefan Schimanski" Date: Mon, 24 Aug 2015 15:02:19 +0200 Subject: [PATCH] Fix sort on sets in hack/verify-flags-underscore.py --- hack/verify-flags-underscore.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hack/verify-flags-underscore.py b/hack/verify-flags-underscore.py index af86f97d9ba..908913a1e0f 100755 --- a/hack/verify-flags-underscore.py +++ b/hack/verify-flags-underscore.py @@ -163,13 +163,15 @@ def get_flags(rootdir, files): if len(new_excluded_flags) != 0: print("Found a flag declared with an _ but which is not explicitly listed as a valid flag name in hack/verify-flags/excluded-flags.txt") print("Are you certain this flag should not have been declared with an - instead?") - new_excluded_flags.sort() - print("%s" % "\n".join(new_excluded_flags)) + l = list(new_excluded_flags) + l.sort() + print("%s" % "\n".join(l)) sys.exit(1) if len(new_flags) != 0: print("Found flags in golang files not in the list of known flags. Please add these to hack/verify-flags/known-flags.txt") - new_flags.sort() - print("%s" % "\n".join(new_flags)) + l = list(new_flags) + l.sort() + print("%s" % "\n".join(l)) sys.exit(1) return list(flags)