From 3a3bdda5ec535c119080aa3e6f4838897437db63 Mon Sep 17 00:00:00 2001 From: harjas Date: Tue, 14 Sep 2021 20:25:56 +0530 Subject: [PATCH] fix: remove extra +1 for printing event count --- pkg/printers/internalversion/printers.go | 6 +----- pkg/printers/internalversion/printers_test.go | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/printers/internalversion/printers.go b/pkg/printers/internalversion/printers.go index b2b6fe648ae..857d20d17e2 100644 --- a/pkg/printers/internalversion/printers.go +++ b/pkg/printers/internalversion/printers.go @@ -1786,11 +1786,7 @@ func printEvent(obj *api.Event, options printers.GenerateOptions) ([]metav1.Tabl count := obj.Count if obj.Series != nil { lastTimestamp = translateMicroTimestampSince(obj.Series.LastObservedTime) - // When a series is created for the first time, its count is set to 1. - // However, for a series to be created, there needs to be an isomorphic - // singleton event created beforehand. This singleton event is not - // counted in the series count which is why one is added here. - count = obj.Series.Count + 1 + count = obj.Series.Count } else if count == 0 { // Singleton events don't have a count set in the new API. count = 1 diff --git a/pkg/printers/internalversion/printers_test.go b/pkg/printers/internalversion/printers_test.go index 4c19d4c20c2..ee8a215cf69 100644 --- a/pkg/printers/internalversion/printers_test.go +++ b/pkg/printers/internalversion/printers_test.go @@ -222,7 +222,7 @@ func TestPrintEvent(t *testing.T) { FieldPath: "spec.containers{foo}", }, Series: &api.EventSeries{ - Count: 1, + Count: 2, LastObservedTime: metav1.MicroTime{Time: time.Now().UTC().AddDate(0, 0, -2)}, }, Reason: "Event Reason",