From bb8157d78011c6331551b30e99fe3b59a6987e5b Mon Sep 17 00:00:00 2001 From: Jan Safranek Date: Fri, 12 Nov 2021 10:45:00 +0100 Subject: [PATCH] Fix deletion protection unit test The test should not depend on current set of default feature gates, it should always ensure the ones necessary for the tests are set. --- pkg/controller/volume/persistentvolume/pv_controller_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/controller/volume/persistentvolume/pv_controller_test.go b/pkg/controller/volume/persistentvolume/pv_controller_test.go index a86a537061b..3da736cf6b0 100644 --- a/pkg/controller/volume/persistentvolume/pv_controller_test.go +++ b/pkg/controller/volume/persistentvolume/pv_controller_test.go @@ -678,6 +678,9 @@ func TestAnnealMigrationAnnotations(t *testing.T) { } func TestUpdateFinalizer(t *testing.T) { + // This set of tests ensures that protection finalizer is removed when CSI migration is disabled + // and PV controller needs to remove finalizers added by the external-provisioner. + defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIMigrationGCE, false)() defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.HonorPVReclaimPolicy, true)() const gcePlugin = "kubernetes.io/gce-pd" const gceDriver = "pd.csi.storage.gke.io"