diff --git a/pkg/apis/batch/validation/validation_test.go b/pkg/apis/batch/validation/validation_test.go index 3e2b0b6e958..fd318c0aafc 100644 --- a/pkg/apis/batch/validation/validation_test.go +++ b/pkg/apis/batch/validation/validation_test.go @@ -17,6 +17,7 @@ limitations under the License. package validation import ( + "runtime" "strings" "testing" @@ -1033,23 +1034,6 @@ func TestValidateCronJob(t *testing.T) { }, }, }, - "spec.timeZone: Invalid value: \"AMERICA/new_york\": unknown time zone AMERICA/new_york": { - ObjectMeta: metav1.ObjectMeta{ - Name: "mycronjob", - Namespace: metav1.NamespaceDefault, - UID: types.UID("1a2b3c"), - }, - Spec: batch.CronJobSpec{ - Schedule: "0 * * * *", - TimeZone: &timeZoneBadCasing, - ConcurrencyPolicy: batch.AllowConcurrent, - JobTemplate: batch.JobTemplateSpec{ - Spec: batch.JobSpec{ - Template: validPodTemplateSpec, - }, - }, - }, - }, "spec.timeZone: Invalid value: \" America/New_York\": unknown time zone America/New_York": { ObjectMeta: metav1.ObjectMeta{ Name: "mycronjob", @@ -1348,6 +1332,26 @@ func TestValidateCronJob(t *testing.T) { }, }, } + if runtime.GOOS != "darwin" { + // Skip this error case on darwin, see https://github.com/golang/go/issues/21512 + errorCases["spec.timeZone: Invalid value: \"AMERICA/new_york\": unknown time zone AMERICA/new_york"] = batch.CronJob{ + ObjectMeta: metav1.ObjectMeta{ + Name: "mycronjob", + Namespace: metav1.NamespaceDefault, + UID: types.UID("1a2b3c"), + }, + Spec: batch.CronJobSpec{ + Schedule: "0 * * * *", + TimeZone: &timeZoneBadCasing, + ConcurrencyPolicy: batch.AllowConcurrent, + JobTemplate: batch.JobTemplateSpec{ + Spec: batch.JobSpec{ + Template: validPodTemplateSpec, + }, + }, + }, + } + } for k, v := range errorCases { errs := ValidateCronJobCreate(&v, corevalidation.PodValidationOptions{})