diff --git a/cmd/kube-apiserver/app/options/plugins.go b/cmd/kube-apiserver/app/options/plugins.go index 1c71ac6b5c2..0e86e7cfdb5 100644 --- a/cmd/kube-apiserver/app/options/plugins.go +++ b/cmd/kube-apiserver/app/options/plugins.go @@ -71,7 +71,7 @@ func RegisterAllAdmissionPlugins(plugins *admission.Plugins) { autoprovision.Register(plugins) exists.Register(plugins) noderestriction.Register(plugins) - label.Register(plugins) + label.Register(plugins) // DEPRECATED in favor of NewPersistentVolumeLabelController in CCM podnodeselector.Register(plugins) podpreset.Register(plugins) podtolerationrestriction.Register(plugins) diff --git a/plugin/pkg/admission/persistentvolume/label/BUILD b/plugin/pkg/admission/persistentvolume/label/BUILD index cbf4432c59e..1e59fb93504 100644 --- a/plugin/pkg/admission/persistentvolume/label/BUILD +++ b/plugin/pkg/admission/persistentvolume/label/BUILD @@ -20,6 +20,7 @@ go_library( "//pkg/kubeapiserver/admission:go_default_library", "//pkg/kubelet/apis:go_default_library", "//pkg/volume:go_default_library", + "//vendor/github.com/golang/glog:go_default_library", "//vendor/k8s.io/apiserver/pkg/admission:go_default_library", ], ) diff --git a/plugin/pkg/admission/persistentvolume/label/admission.go b/plugin/pkg/admission/persistentvolume/label/admission.go index 86083c7d2b9..92dd76f9921 100644 --- a/plugin/pkg/admission/persistentvolume/label/admission.go +++ b/plugin/pkg/admission/persistentvolume/label/admission.go @@ -22,6 +22,7 @@ import ( "io" "sync" + "github.com/golang/glog" "k8s.io/apiserver/pkg/admission" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/cloudprovider" @@ -58,6 +59,11 @@ var _ kubeapiserveradmission.WantsCloudConfig = &persistentVolumeLabel{} // // As a side effect, the cloud provider may block invalid or non-existent volumes. func NewPersistentVolumeLabel() *persistentVolumeLabel { + // DEPRECATED: cloud-controller-manager will now start NewPersistentVolumeLabelController + // which does exactly what this admission controller used to do. So once GCE and AWS can + // run externally, we can remove this admission controller. + glog.Warning("PersistentVolumeLabel admission controller is deprecated. " + + "Please remove this controller from your configuration files and scripts.") return &persistentVolumeLabel{ Handler: admission.NewHandler(admission.Create), }