From 24ab5e9ed0cd01e06fb2df2b3f704f45c780410d Mon Sep 17 00:00:00 2001 From: Ayush Pateria Date: Wed, 31 Jan 2018 00:38:02 +0530 Subject: [PATCH 1/2] Add deprecation comment to PersistentVolumeReclaimRecycle --- pkg/apis/core/types.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/apis/core/types.go b/pkg/apis/core/types.go index bcf3661ba4e..cf359319789 100644 --- a/pkg/apis/core/types.go +++ b/pkg/apis/core/types.go @@ -475,6 +475,7 @@ type PersistentVolumeReclaimPolicy string const ( // PersistentVolumeReclaimRecycle means the volume will be recycled back into the pool of unbound persistent volumes on release from its claim. // The volume plugin must support Recycling. + // This is deprecated. PersistentVolumeReclaimRecycle PersistentVolumeReclaimPolicy = "Recycle" // PersistentVolumeReclaimDelete means the volume will be deleted from Kubernetes on release from its claim. // The volume plugin must support Deletion. From b070c2f6a4d966797201d6cee264b1e227e9863a Mon Sep 17 00:00:00 2001 From: Ayush Pateria Date: Thu, 1 Feb 2018 02:29:55 +0530 Subject: [PATCH 2/2] Elaborate deprecation warning --- pkg/apis/core/types.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/apis/core/types.go b/pkg/apis/core/types.go index cf359319789..75376917208 100644 --- a/pkg/apis/core/types.go +++ b/pkg/apis/core/types.go @@ -475,7 +475,7 @@ type PersistentVolumeReclaimPolicy string const ( // PersistentVolumeReclaimRecycle means the volume will be recycled back into the pool of unbound persistent volumes on release from its claim. // The volume plugin must support Recycling. - // This is deprecated. + // DEPRECATED: The PersistentVolumeReclaimRecycle called Recycle is being deprecated. See announcement here: https://groups.google.com/forum/#!topic/kubernetes-dev/uexugCza84I PersistentVolumeReclaimRecycle PersistentVolumeReclaimPolicy = "Recycle" // PersistentVolumeReclaimDelete means the volume will be deleted from Kubernetes on release from its claim. // The volume plugin must support Deletion.