From 8e7d14196f2807f3e223b2667315966ab8eed13b Mon Sep 17 00:00:00 2001 From: Eric Paris Date: Fri, 10 Apr 2015 17:56:47 -0400 Subject: [PATCH] Fix printing errors from failed binary runs I had the kublet die on startup and the only error was "0x401da0" Which I assume is an address of the err.Error function. The other way to fix this, I think, would be to use err.Error(), however that could cause fmt.Fprintf() problems, debuging on the error message people used. Now I get a nice clean error I can understand: "cAdvisor.New() err = mountpoint for cpu not found" --- cmd/kube-apiserver/apiserver.go | 2 +- cmd/kube-controller-manager/controller-manager.go | 2 +- cmd/kube-proxy/proxy.go | 2 +- cmd/kubelet/kubelet.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/kube-apiserver/apiserver.go b/cmd/kube-apiserver/apiserver.go index 27154cc6063..7e555ed1b77 100644 --- a/cmd/kube-apiserver/apiserver.go +++ b/cmd/kube-apiserver/apiserver.go @@ -42,7 +42,7 @@ func main() { verflag.PrintAndExitIfRequested() if err := s.Run(pflag.CommandLine.Args()); err != nil { - fmt.Fprint(os.Stderr, err.Error) + fmt.Fprint(os.Stderr, "%v\n", err) os.Exit(1) } } diff --git a/cmd/kube-controller-manager/controller-manager.go b/cmd/kube-controller-manager/controller-manager.go index 027474bee1a..ffaf97ec59c 100644 --- a/cmd/kube-controller-manager/controller-manager.go +++ b/cmd/kube-controller-manager/controller-manager.go @@ -49,7 +49,7 @@ func main() { verflag.PrintAndExitIfRequested() if err := s.Run(pflag.CommandLine.Args()); err != nil { - fmt.Fprint(os.Stderr, err.Error) + fmt.Fprint(os.Stderr, "%v\n", err) os.Exit(1) } } diff --git a/cmd/kube-proxy/proxy.go b/cmd/kube-proxy/proxy.go index 487cd140d16..a57255f379b 100644 --- a/cmd/kube-proxy/proxy.go +++ b/cmd/kube-proxy/proxy.go @@ -45,7 +45,7 @@ func main() { verflag.PrintAndExitIfRequested() if err := s.Run(pflag.CommandLine.Args()); err != nil { - fmt.Fprint(os.Stderr, err.Error) + fmt.Fprint(os.Stderr, "%v\n", err) os.Exit(1) } } diff --git a/cmd/kubelet/kubelet.go b/cmd/kubelet/kubelet.go index 78bb915b62c..c956ccd434e 100644 --- a/cmd/kubelet/kubelet.go +++ b/cmd/kubelet/kubelet.go @@ -44,7 +44,7 @@ func main() { verflag.PrintAndExitIfRequested() if err := s.Run(pflag.CommandLine.Args()); err != nil { - fmt.Fprint(os.Stderr, err.Error) + fmt.Fprint(os.Stderr, "%v\n", err) os.Exit(1) } }