From 86a5bd6c19551a0727212c07f9d60fe88e17be75 Mon Sep 17 00:00:00 2001 From: Steve Kuznetsov Date: Tue, 22 Aug 2017 11:08:49 -0700 Subject: [PATCH] Don't silence `go get` during verify scripts When the verify scripts fail to install a component using `go get` today, they silence output go `stderr` and cause the user to not get any actionable feedback on failure. Signed-off-by: Steve Kuznetsov --- hack/lib/util.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hack/lib/util.sh b/hack/lib/util.sh index 5154806ac6e..ab27382c56e 100755 --- a/hack/lib/util.sh +++ b/hack/lib/util.sh @@ -505,7 +505,7 @@ kube::util::ensure_godep_version() { kube::util::ensure-temp-dir mkdir -p "${KUBE_TEMP}/go/src" - GOPATH="${KUBE_TEMP}/go" go get -d -u github.com/tools/godep 2>/dev/null + GOPATH="${KUBE_TEMP}/go" go get -d -u github.com/tools/godep pushd "${KUBE_TEMP}/go/src/github.com/tools/godep" >/dev/null git checkout -q "${GODEP_VERSION}" GOPATH="${KUBE_TEMP}/go" go install . @@ -539,7 +539,7 @@ kube::util::go_install_from_commit() { kube::util::ensure-temp-dir mkdir -p "${KUBE_TEMP}/go/src" - GOPATH="${KUBE_TEMP}/go" go get -d -u "${pkg}" 2>/dev/null + GOPATH="${KUBE_TEMP}/go" go get -d -u "${pkg}" ( cd "${KUBE_TEMP}/go/src/${pkg}" git checkout -q "${commit}"