From 656ea8f98f4b0d6492ca1da43fa0accc7332fbb0 Mon Sep 17 00:00:00 2001 From: "Matt T. Proud" Date: Mon, 18 Jul 2016 16:20:22 +0200 Subject: [PATCH] test/e2e: plug time.Ticker resource leak. This commit ensures that `logPodStartupStatus` does not leak running `time.Ticker` instances. Upon termination of the consuming routine, we stop the ticker. --- test/e2e/density.go | 1 + 1 file changed, 1 insertion(+) diff --git a/test/e2e/density.go b/test/e2e/density.go index b4f5fa3fd01..e58e489bdaf 100644 --- a/test/e2e/density.go +++ b/test/e2e/density.go @@ -151,6 +151,7 @@ func logPodStartupStatus(c *client.Client, expectedPods int, ns string, observed podStore := framework.NewPodStore(c, ns, label, fields.Everything()) defer podStore.Stop() ticker := time.NewTicker(period) + defer ticker.Stop() for { select { case <-ticker.C: