github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #46731 from rmmh/test-only-once

Browse Source 
Automatic merge from submit-queue

Don't rerun certificate manager tests 1000 times.

**What this PR does / why we need it**:
Running every testcase 1000 times needlessly bloats the logs.

**Release note**:
```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-06-19 17:13:06 -07:00 committed by GitHub
commit cfdbc9c028
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
pkg/kubelet/certificate/certificate_manager_test.go
View File

@ -202,21 +202,22 @@ func TestSetRotationDeadline(t *testing.T) {
} }
for _, tc := range testCases { for _, tc := range testCases {
for i := 0; i < 1000; i++ { t.Run(tc.name, func(t *testing.T) {
t.Run(tc.name, func(t *testing.T) { m := manager{
m := manager{ cert: &tls.Certificate{
cert: &tls.Certificate{ Leaf: &x509.Certificate{
Leaf: &x509.Certificate{ NotBefore: tc.notBefore,
NotBefore: tc.notBefore, NotAfter: tc.notAfter,
NotAfter: tc.notAfter,
},
}, },
template: &x509.CertificateRequest{}, },
usages: []certificates.KeyUsage{}, template: &x509.CertificateRequest{},
} usages: []certificates.KeyUsage{},
}
lowerBound := tc.notBefore.Add(time.Duration(float64(tc.notAfter.Sub(tc.notBefore)) * 0.7))
upperBound := tc.notBefore.Add(time.Duration(float64(tc.notAfter.Sub(tc.notBefore)) * 0.9))
for i := 0; i < 1000; i++ {
// setRotationDeadline includes jitter, so this needs to run many times for validation.
m.setRotationDeadline() m.setRotationDeadline()
lowerBound := tc.notBefore.Add(time.Duration(float64(tc.notAfter.Sub(tc.notBefore)) * 0.7))
upperBound := tc.notBefore.Add(time.Duration(float64(tc.notAfter.Sub(tc.notBefore)) * 0.9))
if m.rotationDeadline.Before(lowerBound) || m.rotationDeadline.After(upperBound) { if m.rotationDeadline.Before(lowerBound) || m.rotationDeadline.After(upperBound) {
t.Errorf("For notBefore %v, notAfter %v, the rotationDeadline %v should be between %v and %v.", t.Errorf("For notBefore %v, notAfter %v, the rotationDeadline %v should be between %v and %v.",
tc.notBefore, tc.notBefore,
@ -225,8 +226,8 @@ func TestSetRotationDeadline(t *testing.T) {
lowerBound, lowerBound,
upperBound) upperBound)
} }
}) }
} })
} }
} }