From 4d753d4a597eb33fada99a12d32303359524eac2 Mon Sep 17 00:00:00 2001 From: juanvallejo Date: Fri, 26 Oct 2018 18:35:06 -0400 Subject: [PATCH] fix ContinueOnError visitor --- .../cli-runtime/pkg/genericclioptions/resource/builder.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go b/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go index 6a0d954f80b..42f660a4e53 100644 --- a/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go +++ b/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go @@ -1089,9 +1089,10 @@ func (b *Builder) Do() *Result { if b.requireObject { helpers = append(helpers, RetrieveLazy) } - r.visitor = NewDecoratedVisitor(r.visitor, helpers...) if b.continueOnError { - r.visitor = ContinueOnErrorVisitor{r.visitor} + r.visitor = NewDecoratedVisitor(ContinueOnErrorVisitor{r.visitor}, helpers...) + } else { + r.visitor = NewDecoratedVisitor(r.visitor, helpers...) } return r }