From d0a5cd16da8cec88727274ef4daed4d72f389c35 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 24 Oct 2023 11:19:03 +0200 Subject: [PATCH] e2e upgrades: fix broken assertion It looks like the test is never executed, because it wouldn't pass: an int32 value is never the same as an int 0. Found by the upcoming ginkgolinter update. --- test/e2e/upgrades/node/nvidia-gpu.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/upgrades/node/nvidia-gpu.go b/test/e2e/upgrades/node/nvidia-gpu.go index 512c19b23b6..33f978af7a4 100644 --- a/test/e2e/upgrades/node/nvidia-gpu.go +++ b/test/e2e/upgrades/node/nvidia-gpu.go @@ -57,7 +57,7 @@ func (t *NvidiaGPUUpgradeTest) Test(ctx context.Context, f *framework.Framework, // MasterUpgrade should be totally hitless. job, err := e2ejob.GetJob(ctx, f.ClientSet, f.Namespace.Name, "cuda-add") framework.ExpectNoError(err) - gomega.Expect(job.Status.Failed).To(gomega.Equal(0), "Job pods failed during master upgrade: %v", job.Status.Failed) + gomega.Expect(job.Status.Failed).To(gomega.BeZero(), "Job pods failed during master upgrade: %v", job.Status.Failed) } }