github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

Add missing feature gate to CSI driver uninstall

Browse Source
This commit is contained in:
saad-ali 2018-11-21 15:26:12 -08:00
parent 2b44ec5e9c
commit d1b44857ad
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/volume/csi/nodeinfomanager/nodeinfomanager.go
View File

@ -133,13 +133,14 @@ func (nim *nodeInfoManager) InstallCSIDriver(driverName string, driverNodeID str
// If multiple calls to UninstallCSIDriver() are made in parallel, some calls might receive Node or // If multiple calls to UninstallCSIDriver() are made in parallel, some calls might receive Node or
// CSINodeInfo update conflicts, which causes the function to retry the corresponding update. // CSINodeInfo update conflicts, which causes the function to retry the corresponding update.
func (nim *nodeInfoManager) UninstallCSIDriver(driverName string) error { func (nim *nodeInfoManager) UninstallCSIDriver(driverName string) error {
// TODO: shouldn't this be feature gated? if utilfeature.DefaultFeatureGate.Enabled(features.CSINodeInfo) {
err := nim.uninstallDriverFromCSINodeInfo(driverName) err := nim.uninstallDriverFromCSINodeInfo(driverName)
if err != nil { if err != nil {
return fmt.Errorf("error uninstalling CSI driver from CSINodeInfo object %v", err) return fmt.Errorf("error uninstalling CSI driver from CSINodeInfo object %v", err)
}
} }
err = nim.updateNode( err := nim.updateNode(
removeMaxAttachLimit(driverName), removeMaxAttachLimit(driverName),
removeNodeIDFromNode(driverName), removeNodeIDFromNode(driverName),
) )