From d1b67f96832c81bfe8d5316a5be559f0eb12fb8b Mon Sep 17 00:00:00 2001 From: Justin SB Date: Thu, 14 Jan 2021 11:18:30 -0500 Subject: [PATCH] e2e: DNS autoscaler test was not counting nodes correctly The DNS autoscaler test was not correctly counting tainted but schedulable nodes, meaning that the target count was not correct for clusters with multiple control-plane nodes (which are often tainted but schedulable). The cluster-proportional-autoscaler ignores non-schedulable nodes, but does not consider taints. --- test/e2e/autoscaling/dns_autoscaling.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/autoscaling/dns_autoscaling.go b/test/e2e/autoscaling/dns_autoscaling.go index f81f22a8a28..eaf0e961902 100644 --- a/test/e2e/autoscaling/dns_autoscaling.go +++ b/test/e2e/autoscaling/dns_autoscaling.go @@ -237,7 +237,7 @@ func getExpectReplicasFuncLinear(c clientset.Interface, params *DNSParamsLinear) return func(c clientset.Interface) int { var replicasFromNodes float64 var replicasFromCores float64 - nodes, err := e2enode.GetReadySchedulableNodes(c) + nodes, err := e2enode.GetReadyNodesIncludingTainted(c) framework.ExpectNoError(err) if params.nodesPerReplica > 0 { replicasFromNodes = math.Ceil(float64(len(nodes.Items)) / params.nodesPerReplica)