From d1cb0b7a7a779fa496c4c89f83485bdc2a0faf28 Mon Sep 17 00:00:00 2001
From: Chao Xu <xuchao@google.com>
Date: Mon, 5 Oct 2015 13:24:54 -0700
Subject: [PATCH] returns StatusError in GetAllEventsSinceThreadUnsafe

---
 pkg/storage/watch_cache.go      | 3 ++-
 pkg/storage/watch_cache_test.go | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/pkg/storage/watch_cache.go b/pkg/storage/watch_cache.go
index 5535d41d417..1b376feec1a 100644
--- a/pkg/storage/watch_cache.go
+++ b/pkg/storage/watch_cache.go
@@ -22,6 +22,7 @@ import (
 	"strconv"
 	"sync"
 
+	"k8s.io/kubernetes/pkg/api/errors"
 	"k8s.io/kubernetes/pkg/api/meta"
 	"k8s.io/kubernetes/pkg/client/cache"
 	"k8s.io/kubernetes/pkg/runtime"
@@ -265,7 +266,7 @@ func (w *watchCache) GetAllEventsSinceThreadUnsafe(resourceVersion uint64) ([]wa
 		return result, nil
 	}
 	if resourceVersion < oldest {
-		return nil, fmt.Errorf("too old resource version: %d (%d)", resourceVersion, oldest)
+		return nil, errors.NewInternalError(fmt.Errorf("too old resource version: %d (%d)", resourceVersion, oldest))
 	}
 
 	// Binary seatch the smallest index at which resourceVersion is not smaller than
diff --git a/pkg/storage/watch_cache_test.go b/pkg/storage/watch_cache_test.go
index b50dc9c4b9e..bc62ca85b69 100644
--- a/pkg/storage/watch_cache_test.go
+++ b/pkg/storage/watch_cache_test.go
@@ -21,6 +21,7 @@ import (
 	"testing"
 
 	"k8s.io/kubernetes/pkg/api"
+	"k8s.io/kubernetes/pkg/api/errors"
 	"k8s.io/kubernetes/pkg/api/unversioned"
 	"k8s.io/kubernetes/pkg/client/cache"
 	"k8s.io/kubernetes/pkg/runtime"
@@ -120,6 +121,9 @@ func TestEvents(t *testing.T) {
 		if err == nil {
 			t.Errorf("expected error too old")
 		}
+		if _, ok := err.(*errors.StatusError); !ok {
+			t.Errorf("expected error to be of type StatusError")
+		}
 	}
 	{
 		result, err := store.GetAllEventsSince(2)