github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Add support for make verify WHAT=typecheck.

Browse Source 
This will be used to make the typecheck job emit junit and avoids
duplicating the rest of the verify logic.
This commit is contained in:
Ryan Hitchman 2018-02-28 20:44:37 -08:00
parent f6e23e32f9
commit d295ca1134
2 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
build/root/Makefile
View File

@ -112,10 +112,12 @@ define VERIFY_HELP_INFO
# #
# Args: # Args:
# BRANCH: Branch to be passed to verify-godeps.sh script. # BRANCH: Branch to be passed to verify-godeps.sh script.
# WHAT: List of checks to run
# #
# Example: # Example:
# make verify # make verify
# make verify BRANCH=branch_x # make verify BRANCH=branch_x
# make verify WHAT="bazel typecheck"
endef endef
.PHONY: verify .PHONY: verify
ifeq ($(PRINT_HELP),y) ifeq ($(PRINT_HELP),y)

31
hack/make-rules/verify.sh
View File

@ -73,6 +73,17 @@ function is-quick {
return 1 return 1
} }
function is-explicitly-chosen {
local name="${1#verify-}"
name="${name%.*}"
for e in ${WHAT}; do
if [[ $e == "$name" ]]; then
return
fi
done
return 1
}
function run-cmd { function run-cmd {
local filename="${2##*/verify-}" local filename="${2##*/verify-}"
local testname="${filename%%.*}" local testname="${filename%%.*}"
@ -109,13 +120,19 @@ function run-checks {
for t in $(ls ${pattern}) for t in $(ls ${pattern})
do do
local check_name="$(basename "${t}")" local check_name="$(basename "${t}")"
if is-excluded "${t}" ; then if [[ ! -z ${WHAT:-} ]]; then
echo "Skipping ${check_name}" if ! is-explicitly-chosen "${check_name}"; then
continue continue
fi fi
if ${QUICK} && ! is-quick "${t}" ; then else
echo "Skipping ${check_name} in quick mode" if is-excluded "${t}" ; then
continue echo "Skipping ${check_name}"
continue
fi
if ${QUICK} && ! is-quick "${t}" ; then
echo "Skipping ${check_name} in quick mode"
continue
fi
fi fi
echo -e "Verifying ${check_name}" echo -e "Verifying ${check_name}"
local start=$(date +%s) local start=$(date +%s)