From eac49159a9fef563b6a6fedfd321fdc80621bf17 Mon Sep 17 00:00:00 2001 From: Mayank Kumar Date: Mon, 8 Jan 2018 22:27:29 -0800 Subject: [PATCH] fix userid validation --- pkg/apis/core/validation/validation.go | 4 ++-- pkg/apis/core/validation/validation_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/apis/core/validation/validation.go b/pkg/apis/core/validation/validation.go index b86889a1630..e5dba419354 100644 --- a/pkg/apis/core/validation/validation.go +++ b/pkg/apis/core/validation/validation.go @@ -4813,8 +4813,8 @@ func ValidateSecurityContext(sc *core.SecurityContext, fldPath *field.Path) fiel } if sc.RunAsUser != nil { - if *sc.RunAsUser < 0 { - allErrs = append(allErrs, field.Invalid(fldPath.Child("runAsUser"), *sc.RunAsUser, isNegativeErrorMsg)) + for _, msg := range validation.IsValidUserID(*sc.RunAsUser) { + allErrs = append(allErrs, field.Invalid(fldPath.Child("runAsUser"), *sc.RunAsUser, msg)) } } diff --git a/pkg/apis/core/validation/validation_test.go b/pkg/apis/core/validation/validation_test.go index 442adecfabd..ce8ede0f03e 100644 --- a/pkg/apis/core/validation/validation_test.go +++ b/pkg/apis/core/validation/validation_test.go @@ -11752,7 +11752,7 @@ func TestValidateSecurityContext(t *testing.T) { "negative RunAsUser": { sc: negativeRunAsUser, errorType: "FieldValueInvalid", - errorDetail: isNegativeErrorMsg, + errorDetail: "must be between", }, } for k, v := range errorCases {