add test for Builder to cover kustomization directories

staging/src/k8s.io/cli-runtime/artifacts/kustomization/configMap.yaml

@@ -0,0 +1,8 @@
+
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: the-map
+data:
+  altGreeting: "Good Morning!"
+  enableRisky: "false"

staging/src/k8s.io/cli-runtime/artifacts/kustomization/deployment.yaml

@@ -0,0 +1,30 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: the-deployment
+spec:
+  replicas: 3
+  template:
+    metadata:
+      labels:
+        deployment: hello
+    spec:
+      containers:
+      - name: the-container
+        image: monopole/hello:1
+        command: ["/hello",
+                  "--port=8080",
+                  "--enableRiskyFeature=$(ENABLE_RISKY)"]
+        ports:
+        - containerPort: 8080
+        env:
+        - name: ALT_GREETING
+          valueFrom:
+            configMapKeyRef:
+              name: the-map
+              key: altGreeting
+        - name: ENABLE_RISKY
+          valueFrom:
+            configMapKeyRef:
+              name: the-map
+              key: enableRisky

staging/src/k8s.io/cli-runtime/artifacts/kustomization/kustomization.yaml

@@ -0,0 +1,5 @@
+nameprefix: test-
+resources:
+- deployment.yaml
+- service.yaml
+- configMap.yaml

staging/src/k8s.io/cli-runtime/artifacts/kustomization/service.yaml

@@ -0,0 +1,13 @@
+kind: Service
+apiVersion: v1
+metadata:
+  name: the-service
+spec:
+  selector:
+    deployment: hello
+  type: LoadBalancer
+  ports:
+  - protocol: TCP
+    port: 8666
+    targetPort: 8080
+    

staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder_test.go

@@ -465,27 +465,48 @@ func TestPathBuilderWithMultipleInvalid(t *testing.T) {
 }
 
 func TestDirectoryBuilder(t *testing.T) {
-	b := newDefaultBuilder().
+	tests := []struct {
-		FilenameParam(false, &FilenameOptions{Recursive: false, Filenames: []string{"../../../artifacts/guestbook"}}).
+		directories   []string
-		NamespaceParam("test").DefaultNamespace()
+		singleItem    bool
-
+		number        int
-	test := &testVisitor{}
+		expectedNames []string
-	singleItemImplied := false
+	}{
-
+		{[]string{"../../../artifacts/guestbook"}, false, 3, []string{"redis-master"}},
-	err := b.Do().IntoSingleItemImplied(&singleItemImplied).Visit(test.Handle)
+		{[]string{"../../../artifacts/kustomization"}, true, 3, []string{"test-the-deployment"}},
-	if err != nil || singleItemImplied || len(test.Infos) < 3 {
+		{[]string{"../../../artifacts/guestbook", "../../../artifacts/kustomization"}, false, 6, []string{"redis-master", "test-the-deployment"}},
-		t.Fatalf("unexpected response: %v %t %#v", err, singleItemImplied, test.Infos)
 	}
 
-	found := false
+	for _, tt := range tests {
-	for _, info := range test.Infos {
+		b := newDefaultBuilder().
-		if info.Name == "redis-master" && info.Namespace == "test" && info.Object != nil {
+			FilenameParam(false, &FilenameOptions{Recursive: false, EnableKustomization: true, Filenames: tt.directories}).
-			found = true
+			NamespaceParam("test").DefaultNamespace()
-			break
+
+		test := &testVisitor{}
+		singleItemImplied := false
+
+		err := b.Do().IntoSingleItemImplied(&singleItemImplied).Visit(test.Handle)
+		if err != nil || singleItemImplied != tt.singleItem || len(test.Infos) < tt.number {
+			t.Fatalf("unexpected response: %v %t %#v", err, singleItemImplied, test.Infos)
+		}
+
+		contained := func(name string) bool {
+			for _, info := range test.Infos {
+				if info.Name == name && info.Namespace == "test" && info.Object != nil {
+					return true
+				}
+			}
+			return false
+		}
+
+		allFound := true
+		for _, name := range tt.expectedNames {
+			if !contained(name) {
+				allFound = false
+			}
+		}
+		if !allFound {
+			t.Errorf("unexpected responses: %#v", test.Infos)
 		}
-	}
-	if !found {
-		t.Errorf("unexpected responses: %#v", test.Infos)
 	}
 }