github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #50135 from m1093782566/fed-apiserver-validation

Browse Source 
Automatic merge from submit-queue

add some checks for fedration-apiserver options

**What this PR does / why we need it**:

I find there is a TODO, see https://github.com/kubernetes/kubernetes/blob/master/federation/cmd/federation-apiserver/app/options/validation.go#L30

This PR add some checks for fedration-apiserver options

@sttts 

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-08-11 01:33:00 -07:00 committed by GitHub
commit d40bfff297
3 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
federation/cmd/federation-apiserver/app/options/validation.go
View File

@ -16,6 +16,8 @@ limitations under the License.
package options
import "fmt"
func (options *ServerRunOptions) Validate() []error {
var errors []error
if errs := options.Etcd.Validate(); len(errs) > 0 {
@ -27,6 +29,27 @@ func (options *ServerRunOptions) Validate() []error {
if errs := options.InsecureServing.Validate("insecure-port"); len(errs) > 0 {
errors = append(errors, errs...)
}
if errs := options.Audit.Validate(); len(errs) > 0 {
errors = append(errors, errs...)
}
if errs := options.Features.Validate(); len(errs) > 0 {
errors = append(errors, errs...)
}
if errs := options.Admission.Validate(); len(errs) > 0 {
errors = append(errors, errs...)
}
if errs := options.Authentication.Validate(); len(errs) > 0 {
errors = append(errors, errs...)
}
if errs := options.Authorization.Validate(); len(errs) > 0 {
errors = append(errors, errs...)
}
if errs := options.CloudProvider.Validate(); len(errs) > 0 {
errors = append(errors, errs...)
}
if options.EventTTL <= 0 {
errors = append(errors, fmt.Errorf("--event-ttl must be greater than 0"))
}
// TODO: add more checks
return errors
}

5
staging/src/k8s.io/apiserver/pkg/server/options/admission.go
View File

@ -89,3 +89,8 @@ func (a *AdmissionOptions) ApplyTo(serverCfg *server.Config, pluginInitializers
serverCfg.AdmissionControl = admissionChain
return nil
}
func (a *AdmissionOptions) Validate() []error {
errs := []error{}
return errs
}

5
staging/src/k8s.io/apiserver/pkg/server/options/feature.go
View File

@ -55,3 +55,8 @@ func (o *FeatureOptions) ApplyTo(c *server.Config) error {
return nil
}
func (o *FeatureOptions) Validate() []error {
errs := []error{}
return errs
}