github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 17:30:00 +00:00
Code Issues Projects Releases Wiki Activity

Its bad to spawn a gofunc per quota with large number of quotas

Browse Source
This commit is contained in:
derekwaynecarr 2015-06-12 11:40:14 -04:00
parent 52db576617
commit d40ff87bdc
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/resourcequota/resource_quota_controller.go
View File

@ -17,7 +17,6 @@ limitations under the License.
package resourcequota
import (
"sync"
"time"
"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
@ -63,19 +62,13 @@ func (rm *ResourceQuotaManager) synchronize() {
glog.Errorf("Synchronization error: %v (%#v)", err, err)
}
resourceQuotas = list.Items
wg := sync.WaitGroup{}
wg.Add(len(resourceQuotas))
for ix := range resourceQuotas {
go func(ix int) {
defer wg.Done()
glog.V(4).Infof("periodic sync of %v/%v", resourceQuotas[ix].Namespace, resourceQuotas[ix].Name)
err := rm.syncHandler(resourceQuotas[ix])
if err != nil {
glog.Errorf("Error synchronizing: %v", err)
}
}(ix)
glog.V(4).Infof("periodic sync of %v/%v", resourceQuotas[ix].Namespace, resourceQuotas[ix].Name)
err := rm.syncHandler(resourceQuotas[ix])
if err != nil {
glog.Errorf("Error synchronizing: %v", err)
}
}
wg.Wait()
}
// FilterQuotaPods eliminates pods that no longer have a cost against the quota