Defer DeleteGCEStaticIP before asserting error

This commit is contained in:
Zihong Zheng 2017-06-05 14:24:29 -07:00
parent 0cff839317
commit d455fad134

View File

@ -556,7 +556,6 @@ var _ = framework.KubeDescribe("Services", func() {
By("creating a static load balancer IP") By("creating a static load balancer IP")
staticIPName = fmt.Sprintf("e2e-external-lb-test-%s", framework.RunId) staticIPName = fmt.Sprintf("e2e-external-lb-test-%s", framework.RunId)
requestedIP, err = framework.CreateGCEStaticIP(staticIPName) requestedIP, err = framework.CreateGCEStaticIP(staticIPName)
Expect(err).NotTo(HaveOccurred())
defer func() { defer func() {
if staticIPName != "" { if staticIPName != "" {
// Release GCE static IP - this is not kube-managed and will not be automatically released. // Release GCE static IP - this is not kube-managed and will not be automatically released.
@ -565,6 +564,7 @@ var _ = framework.KubeDescribe("Services", func() {
} }
} }
}() }()
Expect(err).NotTo(HaveOccurred())
framework.Logf("Allocated static load balancer IP: %s", requestedIP) framework.Logf("Allocated static load balancer IP: %s", requestedIP)
} }