From d459b4429f4004708e151f2bef4cf55b7f2ef3d5 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 23 May 2023 21:13:39 +0200 Subject: [PATCH] integration: remove special verbosity for garbagecollector and graph_builder The setting for garbagecollector was added 7 years ago in 9ac91e5172fb for "debugging gc". graph_builder was added 6 years in a98801c1 when restoring the -vmodule parameter after some temporary removal, without an explanation. It seems safe to assume that the garbage collector has been debugged sufficiently... These defaults cause performance overhead: - Enabling -vmodule slows down all log calls because checking verbosity cannot take a simpler fast path. - The amount of log output is much higher for those files. The amount of log data also caused test output to get truncated, removing the actual test failure explanation. --- hack/make-rules/test-integration.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/make-rules/test-integration.sh b/hack/make-rules/test-integration.sh index c42be96672d..f243fe8024c 100755 --- a/hack/make-rules/test-integration.sh +++ b/hack/make-rules/test-integration.sh @@ -41,7 +41,7 @@ KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout=600s} LOG_LEVEL=${LOG_LEVEL:-2} KUBE_TEST_ARGS=${KUBE_TEST_ARGS:-} # Default glog module settings. -KUBE_TEST_VMODULE=${KUBE_TEST_VMODULE:-"garbagecollector*=6,graph_builder*=6"} +KUBE_TEST_VMODULE=${KUBE_TEST_VMODULE:-""} kube::test::find_integration_test_dirs() { (