github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-12 21:36:24 +00:00
Code Issues Projects Releases Wiki Activity

Check return value when calling ensureDnsRecords

Browse Source
This commit is contained in:
xiangpengzhao 2016-07-06 00:02:49 -04:00
parent 31da82df52
commit d4fa23feb8
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
federation/pkg/federation-controller/service/servicecontroller.go
View File

@ -728,11 +728,15 @@ func (s *ServiceController) lockedUpdateDNSRecords(service *cachedService, clust
for key := range s.clusterCache.clientMap { for key := range s.clusterCache.clientMap {
for _, clusterName := range clusterNames { for _, clusterName := range clusterNames {
if key == clusterName { if key == clusterName {
s.ensureDnsRecords(clusterName, service) err := s.ensureDnsRecords(clusterName, service)
if err != nil {
glog.Errorf("Failed to ensure DNS records for service %v in cluster %s due to %v", service, clusterName, err)
} else {
ensuredCount += 1 ensuredCount += 1
} }
} }
} }
}
if ensuredCount < len(clusterNames) { if ensuredCount < len(clusterNames) {
return fmt.Errorf("Failed to update DNS records for %d of %d clusters for service %v due to missing clients for those clusters", return fmt.Errorf("Failed to update DNS records for %d of %d clusters for service %v due to missing clients for those clusters",
len(clusterNames)-ensuredCount, len(clusterNames), service) len(clusterNames)-ensuredCount, len(clusterNames), service)