github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #82029 from losipiuk/lo/runners-scalability

Browse Source 
Allow relaxing deleted pods checking in RC runner
This commit is contained in:
Kubernetes Prow Robot 2019-09-23 09:43:24 -07:00 committed by GitHub
commit d62ebe31f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/utils/runners.go
View File

@ -160,6 +160,9 @@ type RCConfig struct {
// Maximum allowable container failures. If exceeded, RunRC returns an error. // Maximum allowable container failures. If exceeded, RunRC returns an error.
// Defaults to replicas*0.1 if unspecified. // Defaults to replicas*0.1 if unspecified.
MaxContainerFailures *int MaxContainerFailures *int
// Maximum allowed pod deletions count. If exceeded, RunRC returns an error.
// Defaults to 0.
MaxAllowedPodDeletions int
// If set to false starting RC will print progress, otherwise only errors will be printed. // If set to false starting RC will print progress, otherwise only errors will be printed.
Silent bool Silent bool
@ -787,6 +790,7 @@ func (config *RCConfig) start() error {
oldPods := make([]*v1.Pod, 0) oldPods := make([]*v1.Pod, 0)
oldRunning := 0 oldRunning := 0
lastChange := time.Now() lastChange := time.Now()
podDeletionsCount := 0
for oldRunning != config.Replicas { for oldRunning != config.Replicas {
time.Sleep(interval) time.Sleep(interval)
@ -817,9 +821,10 @@ func (config *RCConfig) start() error {
diff := Diff(oldPods, pods) diff := Diff(oldPods, pods)
deletedPods := diff.DeletedPods() deletedPods := diff.DeletedPods()
if len(deletedPods) != 0 { podDeletionsCount += len(deletedPods)
// There are some pods that have disappeared. if podDeletionsCount > config.MaxAllowedPodDeletions {
err := fmt.Errorf("%d pods disappeared for %s: %v", len(deletedPods), config.Name, strings.Join(deletedPods, ", ")) // Number of pods which disappeared is over threshold
err := fmt.Errorf("%d pods disappeared for %s: %v", podDeletionsCount, config.Name, strings.Join(deletedPods, ", "))
config.RCConfigLog(err.Error()) config.RCConfigLog(err.Error())
config.RCConfigLog(diff.String(sets.NewString())) config.RCConfigLog(diff.String(sets.NewString()))
return err return err