From d6b4633432f4bc1b99cdc5dca7f2f8b82e801f82 Mon Sep 17 00:00:00 2001 From: Yu-Ju Hong Date: Tue, 7 Apr 2015 11:55:19 -0700 Subject: [PATCH] Remove unused code in kubelet/server_test.go The code creates a channel and a go routine waiting for update, which is never used by any test. Remove the unused code. --- pkg/kubelet/kubelet_test.go | 26 -------------------------- pkg/kubelet/server_test.go | 7 +------ 2 files changed, 1 insertion(+), 32 deletions(-) diff --git a/pkg/kubelet/kubelet_test.go b/pkg/kubelet/kubelet_test.go index ca8308023de..c324a55a2bc 100644 --- a/pkg/kubelet/kubelet_test.go +++ b/pkg/kubelet/kubelet_test.go @@ -433,32 +433,6 @@ func TestKillContainer(t *testing.T) { } } -type channelReader struct { - list [][]api.Pod - wg sync.WaitGroup -} - -func startReading(channel <-chan interface{}) *channelReader { - cr := &channelReader{} - cr.wg.Add(1) - go func() { - for { - update, ok := <-channel - if !ok { - break - } - cr.list = append(cr.list, update.(PodUpdate).Pods) - } - cr.wg.Done() - }() - return cr -} - -func (cr *channelReader) GetList() [][]api.Pod { - cr.wg.Wait() - return cr.list -} - var emptyPodUIDs map[types.UID]metrics.SyncPodType func TestSyncPodsDoesNothing(t *testing.T) { diff --git a/pkg/kubelet/server_test.go b/pkg/kubelet/server_test.go index 7d0773bc99c..02c2ec8f096 100644 --- a/pkg/kubelet/server_test.go +++ b/pkg/kubelet/server_test.go @@ -112,18 +112,13 @@ func (fk *fakeKubelet) StreamingConnectionIdleTimeout() time.Duration { } type serverTestFramework struct { - updateChan chan interface{} - updateReader *channelReader serverUnderTest *Server fakeKubelet *fakeKubelet testHTTPServer *httptest.Server } func newServerTest() *serverTestFramework { - fw := &serverTestFramework{ - updateChan: make(chan interface{}), - } - fw.updateReader = startReading(fw.updateChan) + fw := &serverTestFramework{} fw.fakeKubelet = &fakeKubelet{ podByNameFunc: func(namespace, name string) (*api.Pod, bool) { return &api.Pod{