From d6f9df424a417187ed495526a8979958e5dfb462 Mon Sep 17 00:00:00 2001 From: Ryan Phillips Date: Mon, 1 Nov 2021 17:02:16 -0500 Subject: [PATCH] defer close the rotated log open --- pkg/kubelet/kuberuntime/logs/logs.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/kubelet/kuberuntime/logs/logs.go b/pkg/kubelet/kuberuntime/logs/logs.go index 428cc2eb65b..9fcb151d647 100644 --- a/pkg/kubelet/kuberuntime/logs/logs.go +++ b/pkg/kubelet/kuberuntime/logs/logs.go @@ -361,6 +361,7 @@ func ReadLogs(ctx context.Context, path, containerID string, opts *LogOptions, r } return fmt.Errorf("failed to open log file %q: %v", path, err) } + defer newF.Close() f.Close() if err := watcher.Remove(f.Name()); err != nil && !os.IsNotExist(err) { klog.ErrorS(err, "Failed to remove file watch", "path", f.Name())