github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Include protocol in the hash for chain names

Browse Source
This commit is contained in:
Tim Hockin 2015-08-14 21:02:53 -07:00
parent 731d5e5191
commit d72892d0b0
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
pkg/proxy/iptables/proxier.go
View File

@ -384,22 +384,23 @@ func flattenValidEndpoints(endpoints []hostPortPair) []string {
return result return result
} }
// servicePortToServiceChain takes the ServicePortName for a // servicePortToServiceChain takes the ServicePortName for a service and
// service and returns the associated iptables chain // returns the associated iptables chain. This is computed by hashing (sha256)
// this is computed by hashing (sha256) then encoding to base64 and // then encoding to base32 and truncating with the prefix "KUBE-SVC-". We do
// truncating with the prefix "KUBE-SVC-" // this because Iptables Chain Names must be <= 28 chars long, and the longer
// We do this because Iptables Chain Names must be <= 28 chars long // they are the harder they are to read.
func servicePortToServiceChain(s proxy.ServicePortName) utiliptables.Chain { func servicePortToServiceChain(s proxy.ServicePortName, protocol string) utiliptables.Chain {
hash := sha256.Sum256([]byte(s.String())) hash := sha256.Sum256([]byte(s.String() + protocol))
encoded := base32.StdEncoding.EncodeToString(hash[:]) encoded := base32.StdEncoding.EncodeToString(hash[:])
return utiliptables.Chain("KUBE-SVC-" + encoded[:19]) return utiliptables.Chain("KUBE-SVC-" + encoded[:16])
} }
// this is the same as servicePortToServiceChain but with the endpoint included essentially // This is the same as servicePortToServiceChain but with the endpoint
func servicePortAndEndpointToServiceChain(s proxy.ServicePortName, endpoint string) utiliptables.Chain { // included.
hash := sha256.Sum256([]byte(s.String() + "_" + endpoint)) func servicePortAndEndpointToServiceChain(s proxy.ServicePortName, protocol string, endpoint string) utiliptables.Chain {
hash := sha256.Sum256([]byte(s.String() + protocol + endpoint))
encoded := base32.StdEncoding.EncodeToString(hash[:]) encoded := base32.StdEncoding.EncodeToString(hash[:])
return utiliptables.Chain("KUBE-SEP-" + encoded[:19]) return utiliptables.Chain("KUBE-SEP-" + encoded[:16])
} }
// This is where all of the iptables-save/restore calls happen. // This is where all of the iptables-save/restore calls happen.
@ -480,10 +481,10 @@ func (proxier *Proxier) syncProxyRules() error {
// Build rules for each service. // Build rules for each service.
for name, info := range proxier.serviceMap { for name, info := range proxier.serviceMap {
protocol := strings.ToLower((string)(info.protocol)) protocol := strings.ToLower(string(info.protocol))
// Create the per-service chain, retaining counters if possible. // Create the per-service chain, retaining counters if possible.
svcChain := servicePortToServiceChain(name) svcChain := servicePortToServiceChain(name, protocol)
if chain, ok := existingChains[svcChain]; ok { if chain, ok := existingChains[svcChain]; ok {
writeLine(chainsLines, chain) writeLine(chainsLines, chain)
} else { } else {
@ -560,7 +561,7 @@ func (proxier *Proxier) syncProxyRules() error {
endpointChains := make([]utiliptables.Chain, 0) endpointChains := make([]utiliptables.Chain, 0)
for _, ep := range info.endpoints { for _, ep := range info.endpoints {
endpoints = append(endpoints, ep) endpoints = append(endpoints, ep)
endpointChain := servicePortAndEndpointToServiceChain(name, ep) endpointChain := servicePortAndEndpointToServiceChain(name, protocol, ep)
endpointChains = append(endpointChains, endpointChain) endpointChains = append(endpointChains, endpointChain)
// Create the endpoint chain, retaining counters if possible. // Create the endpoint chain, retaining counters if possible.