github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-05 07:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Remove unused client in rollout status

Browse Source
This commit is contained in:
Sean Sullivan
2018-09-19 12:35:59 -07:00
parent f3e0750754
commit d73583552c
5 changed files with 15 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/kubectl/rollout_status_test.go
View File

@@ -24,7 +24,6 @@ import (
api "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/client-go/kubernetes/fake"
"k8s.io/kubernetes/pkg/kubectl/scheme"
)
@@ -134,8 +133,7 @@ func TestDeploymentStatusViewerStatus(t *testing.T) {
t.Fatal(err)
}
client := fake.NewSimpleClientset(d).Apps()
dsv := &DeploymentStatusViewer{c: client}
dsv := &DeploymentStatusViewer{}
msg, done, err := dsv.Status(unstructuredD, 0)
if err != nil {
t.Fatalf("DeploymentStatusViewer.Status(): %v", err)
@@ -240,8 +238,7 @@ func TestDaemonSetStatusViewerStatus(t *testing.T) {
t.Fatal(err)
}
client := fake.NewSimpleClientset(d).Apps()
dsv := &DaemonSetStatusViewer{c: client}
dsv := &DaemonSetStatusViewer{}
msg, done, err := dsv.Status(unstructuredD, 0)
if err != nil {
t.Fatalf("unexpected error: %v", err)
@@ -392,8 +389,7 @@ func TestStatefulSetStatusViewerStatus(t *testing.T) {
t.Fatal(err)
}
client := fake.NewSimpleClientset(s).AppsV1()
dsv := &StatefulSetStatusViewer{c: client}
dsv := &StatefulSetStatusViewer{}
msg, done, err := dsv.Status(unstructuredS, 0)
if test.err && err == nil {
t.Fatalf("%s: expected error", test.name)
@@ -431,8 +427,7 @@ func TestDaemonSetStatusViewerStatusWithWrongUpdateStrategyType(t *testing.T) {
t.Fatal(err)
}
client := fake.NewSimpleClientset(d).Apps()
dsv := &DaemonSetStatusViewer{c: client}
dsv := &DaemonSetStatusViewer{}
msg, done, err := dsv.Status(unstructuredD, 0)
errMsg := "rollout status is only available for RollingUpdate strategy type"
if err == nil || err.Error() != errMsg {