diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index 204cf29ead0..4ef3cf855f5 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -10,7 +10,6 @@ vendor/k8s.io/apiserver/pkg/endpoints/filters vendor/k8s.io/apiserver/pkg/endpoints/metrics vendor/k8s.io/apiserver/pkg/server/dynamiccertificates vendor/k8s.io/apiserver/pkg/server/filters -vendor/k8s.io/apiserver/pkg/server/httplog vendor/k8s.io/apiserver/pkg/server/routes vendor/k8s.io/apiserver/pkg/storage vendor/k8s.io/apiserver/pkg/storage/cacher diff --git a/staging/src/k8s.io/apiserver/pkg/server/httplog/httplog.go b/staging/src/k8s.io/apiserver/pkg/server/httplog/httplog.go index 386d5b9ca2b..92b9b1285cf 100644 --- a/staging/src/k8s.io/apiserver/pkg/server/httplog/httplog.go +++ b/staging/src/k8s.io/apiserver/pkg/server/httplog/httplog.go @@ -66,6 +66,9 @@ type respLogger struct { // Simple logger that logs immediately when Addf is called type passthroughLogger struct{} +//lint:ignore SA1019 Interface implementation check to make sure we don't drop CloseNotifier again +var _ http.CloseNotifier = &respLogger{} + // Addf logs info immediately. func (passthroughLogger) Addf(format string, data ...interface{}) { klog.V(2).Info(fmt.Sprintf(format, data...)) @@ -239,6 +242,7 @@ func (rl *respLogger) Hijack() (net.Conn, *bufio.ReadWriter, error) { // CloseNotify implements http.CloseNotifier func (rl *respLogger) CloseNotify() <-chan bool { + //lint:ignore SA1019 There are places in the code base requiring the CloseNotifier interface to be implemented. return rl.w.(http.CloseNotifier).CloseNotify() }