diff --git a/hack/.golint_failures b/hack/.golint_failures index 8ab29fc3b7a..6c557311951 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -358,7 +358,6 @@ pkg/volume/scaleio pkg/volume/storageos pkg/volume/testing pkg/volume/util/fs -pkg/volume/util/recyclerclient pkg/volume/util/volumepathhandler pkg/volume/vsphere_volume plugin/pkg/admission/antiaffinity diff --git a/pkg/volume/util/recyclerclient/recycler_client.go b/pkg/volume/util/recyclerclient/recycler_client.go index c7a8f147f87..0011c1cf493 100644 --- a/pkg/volume/util/recyclerclient/recycler_client.go +++ b/pkg/volume/util/recyclerclient/recycler_client.go @@ -29,6 +29,7 @@ import ( "k8s.io/klog" ) +// RecycleEventRecorder is a func that defines how to record RecycleEvent. type RecycleEventRecorder func(eventtype, message string) // RecycleVolumeByWatchingPodUntilCompletion is intended for use with volume @@ -127,9 +128,8 @@ func waitForPod(pod *v1.Pod, recyclerClient recyclerClient, podCh <-chan watch.E if pod.Status.Phase == v1.PodFailed { if pod.Status.Message != "" { return fmt.Errorf(pod.Status.Message) - } else { - return fmt.Errorf("pod failed, pod.Status.Message unknown.") } + return fmt.Errorf("pod failed, pod.Status.Message unknown") } case watch.Deleted: @@ -238,9 +238,8 @@ func (c *realRecyclerClient) WatchPod(name, namespace string, stopChannel chan s case eventEvent, ok := <-eventWatch.ResultChan(): if !ok { return - } else { - eventCh <- eventEvent } + eventCh <- eventEvent } } }() @@ -256,9 +255,8 @@ func (c *realRecyclerClient) WatchPod(name, namespace string, stopChannel chan s case podEvent, ok := <-podWatch.ResultChan(): if !ok { return - } else { - eventCh <- podEvent } + eventCh <- podEvent } } }() diff --git a/pkg/volume/util/recyclerclient/recycler_client_test.go b/pkg/volume/util/recyclerclient/recycler_client_test.go index e4182dd0f31..1182dc4e124 100644 --- a/pkg/volume/util/recyclerclient/recycler_client_test.go +++ b/pkg/volume/util/recyclerclient/recycler_client_test.go @@ -210,9 +210,8 @@ func (c *mockRecyclerClient) CreatePod(pod *v1.Pod) (*v1.Pod, error) { func (c *mockRecyclerClient) GetPod(name, namespace string) (*v1.Pod, error) { if c.pod != nil { return c.pod, nil - } else { - return nil, fmt.Errorf("pod does not exist") } + return nil, fmt.Errorf("pod does not exist") } func (c *mockRecyclerClient) DeletePod(name, namespace string) error {