github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-12-20 18:33:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #121888 from SD-13/e2e-gomega-be-true-or-false

Browse Source 
Enhance boolean assertions when fail
This commit is contained in:
Kubernetes Prow Robot
2024-08-20 04:24:42 -07:00
committed by GitHub
parent b8dcc2c983 223aedcf6b
commit d770dd695a
35 changed files with 135 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e_node/kubelet_config_dir_test.go
View File

@@ -59,7 +59,7 @@ var _ = SIGDescribe("Kubelet Config", framework.WithSlow(), framework.WithSerial
// wait until the kubelet health check will fail
gomega.Eventually(ctx, func() bool {
return kubeletHealthCheck(kubeletHealthCheckURL)
}, f.Timeouts.PodStart, f.Timeouts.Poll).Should(gomega.BeFalse())
}, f.Timeouts.PodStart, f.Timeouts.Poll).Should(gomega.BeFalseBecause("expected kubelet health check to be failed"))
configDir := framework.TestContext.KubeletConfigDropinDir
@@ -132,7 +132,7 @@ featureGates:
// wait until the kubelet health check will succeed
gomega.Eventually(ctx, func() bool {
return kubeletHealthCheck(kubeletHealthCheckURL)
}, f.Timeouts.PodStart, f.Timeouts.Poll).Should(gomega.BeTrue())
}, f.Timeouts.PodStart, f.Timeouts.Poll).Should(gomega.BeTrueBecause("expected kubelet to be in healthy state"))
mergedConfig, err := getCurrentKubeletConfig(ctx)
framework.ExpectNoError(err)