github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix error checks after cloning.

Browse Source 
We should not use clone result When cloning fails. Fixes issues found in #28108.
This commit is contained in:
Jan Safranek 2016-06-28 10:01:52 +02:00
parent d5e60cefc4
commit d78946240e
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/persistentvolume/controller_base.go
View File

@ -152,6 +152,7 @@ func (ctrl *PersistentVolumeController) initializeCaches(volumeSource, claimSour
clone, err := conversion.NewCloner().DeepCopy(&volume) clone, err := conversion.NewCloner().DeepCopy(&volume)
if err != nil { if err != nil {
glog.Errorf("error cloning volume %q: %v", volume.Name, err) glog.Errorf("error cloning volume %q: %v", volume.Name, err)
continue
} }
volumeClone := clone.(*api.PersistentVolume) volumeClone := clone.(*api.PersistentVolume)
ctrl.storeVolumeUpdate(volumeClone) ctrl.storeVolumeUpdate(volumeClone)
@ -172,6 +173,7 @@ func (ctrl *PersistentVolumeController) initializeCaches(volumeSource, claimSour
clone, err := conversion.NewCloner().DeepCopy(&claim) clone, err := conversion.NewCloner().DeepCopy(&claim)
if err != nil { if err != nil {
glog.Errorf("error cloning claim %q: %v", claimToClaimKey(&claim), err) glog.Errorf("error cloning claim %q: %v", claimToClaimKey(&claim), err)
continue
} }
claimClone := clone.(*api.PersistentVolumeClaim) claimClone := clone.(*api.PersistentVolumeClaim)
ctrl.storeClaimUpdate(claimClone) ctrl.storeClaimUpdate(claimClone)