github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-05 23:47:50 +00:00
Code Issues Projects Releases Wiki Activity

Handle ImplementedElsewhere error in service_controller

Browse Source 
This is used when the cloudprovider layer is not implementing loadBalancer service.
Implementation will be in a different controller running on master.
This commit is contained in:
Pavithra Ramesh
2019-07-15 00:01:33 -07:00
parent 5623006f98
commit d79d4e8525
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/controller/service/service_controller.go
View File

@@ -339,6 +339,10 @@ func (s *ServiceController) syncLoadBalancerIfNeeded(service *v1.Service, key st
}
newStatus, err = s.ensureLoadBalancer(service)
if err != nil {
if err == cloudprovider.ImplementedElsewhere {
klog.Infof("LoadBalancer for service %s not implemented by alternate controller %s, Ignoring error", key, s.cloud.ProviderName())
return op, nil
}
return op, fmt.Errorf("failed to ensure load balancer: %v", err)
}
s.eventRecorder.Event(service, v1.EventTypeNormal, "EnsuredLoadBalancer", "Ensured load balancer")
@@ -703,7 +707,12 @@ func (s *ServiceController) lockedUpdateLoadBalancerHosts(service *v1.Service, h
}
return nil
}
if err == cloudprovider.ImplementedElsewhere {
// Skip error since LoadBalancer implementation is in some other controller. In this case, the loadBalancer will likely not
// exist and will be handled in the if block below. Adding this check in case the alternate loadBalancer implementation
// uses the same naming scheme.
return nil
}
// It's only an actual error if the load balancer still exists.
if _, exists, err := s.balancer.GetLoadBalancer(context.TODO(), s.clusterName, service); err != nil {
runtime.HandleError(fmt.Errorf("failed to check if load balancer exists for service %s/%s: %v", service.Namespace, service.Name, err))