From b0f38b223edf98dfa109c6e17123f843e1a8a769 Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov" Date: Tue, 20 Dec 2022 16:28:28 +0200 Subject: [PATCH] kubeadm: revert feature to backup kubelet config for "upgrade node" There seems to be a bug where it's not possible to write to /etc/kubernetes/tmp... at the time of backing up the old kubelet config.yaml Also this kubelet config backup only targets "upgrade node" and it should also target "upgrade apply". Revert the related changes until a fully working feature is implemented. --- .../app/cmd/phases/upgrade/node/kubeletconfig.go | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go b/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go index 2eb50565203..d1c66dfd02c 100644 --- a/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go +++ b/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go @@ -71,21 +71,6 @@ func runKubeletConfigPhase() func(c workflow.RunData) error { return err } - // Create a copy of the kubelet config file in the /etc/kubernetes/tmp/ folder. - backupDir, err := constants.CreateTempDirForKubeadm(constants.KubernetesDir, "kubeadm-kubelet-config") - if err != nil { - return err - } - src := filepath.Join(kubeletDir, constants.KubeletConfigurationFileName) - dest := filepath.Join(backupDir, constants.KubeletConfigurationFileName) - if !dryRun { - fmt.Printf("[upgrade] Backing up kubelet config file to %s\n", dest) - if err := os.Rename(src, dest); err != nil { - return errors.Wrap(err, "error backing up the kubelet config file") - } - } else { - fmt.Printf("[dryrun] Would back up kubelet config file to %s\n", dest) - } // Store the kubelet component configuration. if err = kubeletphase.WriteConfigToDisk(&cfg.ClusterConfiguration, kubeletDir, data.PatchesDir(), data.OutputWriter()); err != nil { return err