mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-22 03:11:40 +00:00
Merge pull request #46099 from shashidharatd/revert-45798-federated-service
Automatic merge from submit-queue (batch tested with PRs 47851, 47824, 47858, 46099) Revert "[Federation] Fix federated service reconcilation issue due to addition of External…" Reverts kubernetes/kubernetes#45798 Reverting the temporary fix as the problem is fixed in #45869. with that fix federation also can default ExternalTrafficLocalOnly if not set. Issue: #45812 cc @MrHohn @madhusudancs @kubernetes/sig-federation-bugs
This commit is contained in:
commit
d86c267112
@ -566,11 +566,6 @@ func getOperationsToPerformOnCluster(informer fedutil.FederatedInformer, cluster
|
||||
}
|
||||
}
|
||||
}
|
||||
// If ExternalTrafficPolicy is not set in federated service, use the ExternalTrafficPolicy
|
||||
// defaulted to in federated cluster.
|
||||
if desiredService.Spec.ExternalTrafficPolicy == v1.ServiceExternalTrafficPolicyType("") {
|
||||
desiredService.Spec.ExternalTrafficPolicy = clusterService.Spec.ExternalTrafficPolicy
|
||||
}
|
||||
|
||||
// Update existing service, if needed.
|
||||
if !Equivalent(desiredService, clusterService) {
|
||||
|
@ -379,13 +379,10 @@ func deleteServiceShard(c *fedframework.Cluster, namespace, service string) erro
|
||||
|
||||
// equivalent returns true if the two services are equivalent. Fields which are expected to differ between
|
||||
// federated services and the underlying cluster services (e.g. ClusterIP, NodePort) are ignored.
|
||||
func equivalent(clusterService, federationService v1.Service) bool {
|
||||
federationService.Spec.ClusterIP = clusterService.Spec.ClusterIP
|
||||
for i := range federationService.Spec.Ports {
|
||||
federationService.Spec.Ports[i].NodePort = clusterService.Spec.Ports[i].NodePort
|
||||
}
|
||||
if federationService.Spec.ExternalTrafficPolicy == v1.ServiceExternalTrafficPolicyType("") {
|
||||
federationService.Spec.ExternalTrafficPolicy = clusterService.Spec.ExternalTrafficPolicy
|
||||
func equivalent(federationService, clusterService v1.Service) bool {
|
||||
clusterService.Spec.ClusterIP = federationService.Spec.ClusterIP
|
||||
for i := range clusterService.Spec.Ports {
|
||||
clusterService.Spec.Ports[i].NodePort = federationService.Spec.Ports[i].NodePort
|
||||
}
|
||||
|
||||
if federationService.Name != clusterService.Name || federationService.Namespace != clusterService.Namespace {
|
||||
|
Loading…
Reference in New Issue
Block a user