github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-18 16:21:13 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #85402 from RainbowMango/pr_remove_metrics_hidden_log

Browse Source 
Remove metric be hidden log temporarily
This commit is contained in:
Kubernetes Prow Robot 2019-11-21 18:19:29 -08:00 committed by GitHub
commit d87c921a51
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/component-base/metrics/desc.go
View File

@ -119,7 +119,8 @@ func (d *Desc) determineDeprecationStatus(version semver.Version) {
return return
} }
if shouldHide(&version, selfVersion) { if shouldHide(&version, selfVersion) {
klog.Warningf("This metric(%s) has been deprecated for more than one release, hiding.", d.fqName) // TODO(RainbowMango): Remove this log temporarily. https://github.com/kubernetes/kubernetes/issues/85369
// klog.Warningf("This metric(%s) has been deprecated for more than one release, hiding.", d.fqName)
d.isHidden = true d.isHidden = true
} }
}) })

3
staging/src/k8s.io/component-base/metrics/metric.go
View File

@ -102,7 +102,8 @@ func (r *lazyMetric) determineDeprecationStatus(version semver.Version) {
return return
} }
if shouldHide(&version, selfVersion) { if shouldHide(&version, selfVersion) {
klog.Warningf("This metric has been deprecated for more than one release, hiding.") // TODO(RainbowMango): Remove this log temporarily. https://github.com/kubernetes/kubernetes/issues/85369
// klog.Warningf("This metric has been deprecated for more than one release, hiding.")
r.isHidden = true r.isHidden = true
} }
}) })