github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 02:41:25 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #92917 from maryamklabib/staticcheck_fix

Browse Source 
Resolves staticcheck failures for component-base/metrics
This commit is contained in:
Kubernetes Prow Robot 2020-08-27 20:15:02 -07:00 committed by GitHub
commit d8937faf23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hack/.staticcheck_failures
View File

@ -63,7 +63,6 @@ vendor/k8s.io/client-go/rest/watch
vendor/k8s.io/client-go/restmapper vendor/k8s.io/client-go/restmapper
vendor/k8s.io/client-go/tools/leaderelection vendor/k8s.io/client-go/tools/leaderelection
vendor/k8s.io/client-go/transport vendor/k8s.io/client-go/transport
vendor/k8s.io/component-base/metrics
vendor/k8s.io/kubectl/pkg/cmd/get vendor/k8s.io/kubectl/pkg/cmd/get
vendor/k8s.io/kubectl/pkg/cmd/scale vendor/k8s.io/kubectl/pkg/cmd/scale
vendor/k8s.io/kubectl/pkg/cmd/testing vendor/k8s.io/kubectl/pkg/cmd/testing

3
staging/src/k8s.io/component-base/metrics/metric.go
View File

@ -188,9 +188,6 @@ func (c *selfCollector) Collect(ch chan<- prometheus.Metric) {
// no-op vecs for convenience // no-op vecs for convenience
var noopCounterVec = &prometheus.CounterVec{} var noopCounterVec = &prometheus.CounterVec{}
var noopHistogramVec = &prometheus.HistogramVec{} var noopHistogramVec = &prometheus.HistogramVec{}
// lint:ignore U1000 Keep it for future use
var noopSummaryVec = &prometheus.SummaryVec{}
var noopGaugeVec = &prometheus.GaugeVec{} var noopGaugeVec = &prometheus.GaugeVec{}
var noopObserverVec = &noopObserverVector{} var noopObserverVec = &noopObserverVector{}

2
staging/src/k8s.io/component-base/metrics/processstarttime.go
View File

@ -54,7 +54,7 @@ func getProcessStart() (float64, error) {
return 0, err return 0, err
} }
if stat, err := p.NewStat(); err == nil { if stat, err := p.Stat(); err == nil {
return stat.StartTime() return stat.StartTime()
} }
return 0, err return 0, err