diff --git a/cluster/images/etcd/migrate/versions.go b/cluster/images/etcd/migrate/versions.go index bdb7cd048a8..ea1d8d7bf27 100644 --- a/cluster/images/etcd/migrate/versions.go +++ b/cluster/images/etcd/migrate/versions.go @@ -126,6 +126,7 @@ func ParseEtcdVersionPair(s string) (*EtcdVersionPair, error) { // MustParseEtcdVersionPair parses a "/" string to an EtcdVersionPair // or panics if the parse fails. +//lint:ignore U1000 Keep unused but exported MustParseEtcdVersionPair until deprecated package is being removed func MustParseEtcdVersionPair(s string) *EtcdVersionPair { pair, err := ParseEtcdVersionPair(s) if err != nil { @@ -188,6 +189,7 @@ func ParseSupportedVersions(list []string) (SupportedVersions, error) { } // MustParseSupportedVersions parses a comma separated list of etcd versions or panics if the parse fails. +//lint:ignore U1000 Keep unused but exported MustParseSupportedVersions until deprecated package is being removed func MustParseSupportedVersions(list []string) SupportedVersions { versions, err := ParseSupportedVersions(list) if err != nil { diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index 99abea7bc69..c3e3e7b33a7 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -1,8 +1,3 @@ -cluster/images/etcd/migrate -vendor/k8s.io/apimachinery/pkg/api/apitesting/roundtrip -vendor/k8s.io/apimachinery/pkg/apis/meta/v1/validation -vendor/k8s.io/apiserver/pkg/endpoints/filters -vendor/k8s.io/apiserver/pkg/endpoints/metrics vendor/k8s.io/apiserver/pkg/server/dynamiccertificates vendor/k8s.io/apiserver/pkg/server/filters vendor/k8s.io/apiserver/pkg/server/routes diff --git a/staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip/roundtrip.go b/staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip/roundtrip.go index 89c1d1ca8e0..0c320e578b9 100644 --- a/staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip/roundtrip.go +++ b/staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip/roundtrip.go @@ -25,6 +25,7 @@ import ( "testing" "github.com/davecgh/go-spew/spew" + //lint:ignore SA1019 Keep using deprecated module; it still seems to be maintained and the api of the recommended replacement differs "github.com/golang/protobuf/proto" fuzz "github.com/google/gofuzz" flag "github.com/spf13/pflag" diff --git a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation.go b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation.go index 6706103ee18..bd82a9d651f 100644 --- a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation.go +++ b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation.go @@ -81,6 +81,7 @@ func ValidateLabels(labels map[string]string, fldPath *field.Path) field.ErrorLi func ValidateDeleteOptions(options *metav1.DeleteOptions) field.ErrorList { allErrs := field.ErrorList{} + //lint:file-ignore SA1019 Keep validation for deprecated OrphanDependents option until it's being removed if options.OrphanDependents != nil && options.PropagationPolicy != nil { allErrs = append(allErrs, field.Invalid(field.NewPath("propagationPolicy"), options.PropagationPolicy, "orphanDependents and deletionPropagation cannot be both set")) } diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/filters/audit.go b/staging/src/k8s.io/apiserver/pkg/endpoints/filters/audit.go index 853d1da9fd4..02f57909ef0 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/filters/audit.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/filters/audit.go @@ -173,6 +173,7 @@ func decorateResponseWriter(ctx context.Context, responseWriter http.ResponseWri // check if the ResponseWriter we're wrapping is the fancy one we need // or if the basic is sufficient + //lint:file-ignore SA1019 Keep supporting deprecated http.CloseNotifier _, cn := responseWriter.(http.CloseNotifier) _, fl := responseWriter.(http.Flusher) _, hj := responseWriter.(http.Hijacker) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go index 1640ce38611..cafb6187496 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go @@ -469,6 +469,7 @@ func InstrumentRouteFunc(verb, group, version, resource, subresource, scope, com delegate := &ResponseWriterDelegator{ResponseWriter: response.ResponseWriter} + //lint:file-ignore SA1019 Keep supporting deprecated http.CloseNotifier _, cn := response.ResponseWriter.(http.CloseNotifier) _, fl := response.ResponseWriter.(http.Flusher) _, hj := response.ResponseWriter.(http.Hijacker)