From c6da6021685c7ab7713c2562ada535631141f8dc Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Mon, 9 Jan 2023 08:03:39 +0100 Subject: [PATCH 1/2] OWNERS: remove sig-testing-approvers It's not used enough to add any real value. Instead, it obscures the real ownership when someone looks at an OWNERS file where it is used. --- OWNERS_ALIASES | 7 ------- hack/jenkins/OWNERS | 4 +++- test/OWNERS | 4 +++- test/e2e/framework/OWNERS | 1 - 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 4074abdb810..34777658c61 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -216,13 +216,6 @@ aliases: - cblecker - spiffxp - dims - sig-testing-approvers: - - bentheelder - - cblecker - - spiffxp - # emeritus - # - ixdy - # - krzyzacy sig-node-approvers: - Random-Liu - dchen1107 diff --git a/hack/jenkins/OWNERS b/hack/jenkins/OWNERS index d996011f281..2c6bfec751c 100644 --- a/hack/jenkins/OWNERS +++ b/hack/jenkins/OWNERS @@ -1,6 +1,8 @@ # See the OWNERS docs at https://go.k8s.io/owners approvers: - - sig-testing-approvers + - bentheelder + - cblecker + - spiffxp reviewers: - sig-testing-reviewers diff --git a/test/OWNERS b/test/OWNERS index f229010745d..41f6f027076 100644 --- a/test/OWNERS +++ b/test/OWNERS @@ -36,9 +36,9 @@ approvers: - pwittrock # for test/e2e/kubectl.go - saad-ali - SataQiu - - sig-testing-approvers - smarterclayton - soltysh + - spiffxp - sttts - thockin - wojtek-t @@ -46,7 +46,9 @@ emeritus_approvers: - eparis - foxish - gmarek + - ixdy - krousey + - krzyzacy - kow3ns - madhusudancs - marun diff --git a/test/e2e/framework/OWNERS b/test/e2e/framework/OWNERS index 0f377351bc1..f12bdef922d 100644 --- a/test/e2e/framework/OWNERS +++ b/test/e2e/framework/OWNERS @@ -1,7 +1,6 @@ # See the OWNERS docs at https://go.k8s.io/owners approvers: - - sig-testing-approvers - andrewsykim - fabriziopandini - pohly From b721272a1e9acc4cfd1c7fde31c0d621a689002b Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 3 Jan 2023 09:30:37 +0100 Subject: [PATCH 2/2] test/OWNERS: add pohly as approver As technical lead in SIG Testing it would be useful to have the right to approve test changes... --- test/OWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/test/OWNERS b/test/OWNERS index 41f6f027076..f72ddcb886d 100644 --- a/test/OWNERS +++ b/test/OWNERS @@ -33,6 +33,7 @@ approvers: - msau42 - neolit123 - oomichi + - pohly - pwittrock # for test/e2e/kubectl.go - saad-ali - SataQiu