From d8d16a79ee8283deb1355fa9123a32a4e426a7dc Mon Sep 17 00:00:00 2001 From: Antoine Pelisse Date: Wed, 16 Aug 2017 09:05:18 -0700 Subject: [PATCH] apimachinery: Print unknown transport type The current error message prints a pointer value rather than the actual type, which is really not useful. e.g.: ``` unknown transport type: &{0xc42044a7b0 0xc4208d6dc0} unknown transport type: *gcp.conditionalTransport ``` --- staging/src/k8s.io/apimachinery/pkg/util/net/http.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apimachinery/pkg/util/net/http.go b/staging/src/k8s.io/apimachinery/pkg/util/net/http.go index a48f16543c9..77488388c64 100644 --- a/staging/src/k8s.io/apimachinery/pkg/util/net/http.go +++ b/staging/src/k8s.io/apimachinery/pkg/util/net/http.go @@ -108,7 +108,7 @@ func DialerFor(transport http.RoundTripper) (DialFunc, error) { case RoundTripperWrapper: return DialerFor(transport.WrappedRoundTripper()) default: - return nil, fmt.Errorf("unknown transport type: %v", transport) + return nil, fmt.Errorf("unknown transport type: %T", transport) } } @@ -129,7 +129,7 @@ func TLSClientConfig(transport http.RoundTripper) (*tls.Config, error) { case RoundTripperWrapper: return TLSClientConfig(transport.WrappedRoundTripper()) default: - return nil, fmt.Errorf("unknown transport type: %v", transport) + return nil, fmt.Errorf("unknown transport type: %T", transport) } }