github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

DRA scheduler: fix potential panic during unit test verification

Browse Source 
If there was an unexpected status, the code extracting the expected error
message crashed with a panic. Happened once so far, for unknown reasons
because the unexpected status then didn't get logged.
This commit is contained in:
Patrick Ohly 2025-03-18 12:18:25 +01:00
parent bce5886c97
commit d95d6ba526
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/scheduler/framework/plugins/dynamicresources/dynamicresources_test.go
View File

@ -1047,7 +1047,9 @@ type testContext struct {
func (tc *testContext) verify(t *testing.T, expected result, initialObjects []metav1.Object, result interface{}, status *framework.Status) { func (tc *testContext) verify(t *testing.T, expected result, initialObjects []metav1.Object, result interface{}, status *framework.Status) {
t.Helper() t.Helper()
if actualErr := status.AsError(); actualErr != nil { if expected.status == nil {
assert.Nil(t, status)
} else if actualErr := status.AsError(); actualErr != nil {
// Compare only the error strings. // Compare only the error strings.
assert.ErrorContains(t, actualErr, expected.status.AsError().Error()) assert.ErrorContains(t, actualErr, expected.status.AsError().Error())
} else { } else {