From d9737eabf49f7e228eb32bf70ef2936804b0694c Mon Sep 17 00:00:00 2001 From: CatherineF-dev Date: Fri, 12 Nov 2021 23:09:51 +0000 Subject: [PATCH] Use HandlerFor --- pkg/kubelet/kuberuntime/instrumented_services_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/kuberuntime/instrumented_services_test.go b/pkg/kubelet/kuberuntime/instrumented_services_test.go index b343320c8a2..e95d6bdb74a 100644 --- a/pkg/kubelet/kuberuntime/instrumented_services_test.go +++ b/pkg/kubelet/kuberuntime/instrumented_services_test.go @@ -22,7 +22,6 @@ import ( "testing" "time" - "github.com/prometheus/client_golang/prometheus/promhttp" "github.com/stretchr/testify/assert" compbasemetrics "k8s.io/component-base/metrics" @@ -33,6 +32,7 @@ import ( func TestRecordOperation(t *testing.T) { // Use local registry var registry = compbasemetrics.NewKubeRegistry() + var gather compbasemetrics.Gatherer = registry defer registry.Reset() registry.MustRegister(metrics.RuntimeOperations) registry.MustRegister(metrics.RuntimeOperationsDuration) @@ -44,7 +44,7 @@ func TestRecordOperation(t *testing.T) { prometheusURL := "http://" + l.Addr().String() + "/metrics" mux := http.NewServeMux() - handler := promhttp.HandlerFor(registry, promhttp.HandlerOpts{}) + handler := compbasemetrics.HandlerFor(gather, compbasemetrics.HandlerOpts{}) mux.Handle("/metrics", handler) server := &http.Server{ Addr: l.Addr().String(),