From d9939a34d933f469989edf2135eb33cba5b7a4ba Mon Sep 17 00:00:00 2001 From: houjun Date: Tue, 23 Mar 2021 17:21:07 +0800 Subject: [PATCH] Missing return on error --- pkg/scheduler/framework/plugins/interpodaffinity/scoring.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/scheduler/framework/plugins/interpodaffinity/scoring.go b/pkg/scheduler/framework/plugins/interpodaffinity/scoring.go index 357c6ad15d1..464e0f3b5d1 100644 --- a/pkg/scheduler/framework/plugins/interpodaffinity/scoring.go +++ b/pkg/scheduler/framework/plugins/interpodaffinity/scoring.go @@ -149,12 +149,12 @@ func (pl *InterPodAffinity) PreScore( if hasPreferredAffinityConstraints || hasPreferredAntiAffinityConstraints { allNodes, err = pl.sharedLister.NodeInfos().List() if err != nil { - framework.AsStatus(fmt.Errorf("failed to get all nodes from shared lister: %w", err)) + return framework.AsStatus(fmt.Errorf("failed to get all nodes from shared lister: %w", err)) } } else { allNodes, err = pl.sharedLister.NodeInfos().HavePodsWithAffinityList() if err != nil { - framework.AsStatus(fmt.Errorf("failed to get pods with affinity list: %w", err)) + return framework.AsStatus(fmt.Errorf("failed to get pods with affinity list: %w", err)) } }