github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 09:49:50 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #10086 from marekbiskup/issues-for-TODO

Browse Source 
add issue reference to TODOs
This commit is contained in:
Piotr Szczesniak 2015-06-19 13:19:30 +02:00
commit d9dabd749c
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/e2e/resize_nodes.go
View File

@ -278,10 +278,12 @@ func performTemporaryNetworkFailure(c *client.Client, ns, rcName string, replica
} }
By(fmt.Sprintf("block network traffic from node %s to the master", node.Name)) By(fmt.Sprintf("block network traffic from node %s to the master", node.Name))
// TODO: The use of MasterName will cause iptables to do a DNS lookup to // TODO marekbiskup 2015-06-19 #10085
// The use of MasterName will cause iptables to do a DNS lookup to
// resolve the name to an IP address, which will slow down the test // resolve the name to an IP address, which will slow down the test
// and cause it to fail if DNS is absent or broken. // and cause it to fail if DNS is absent or broken.
// Use the IP address instead. // Use the IP address instead.
iptablesRule := fmt.Sprintf("OUTPUT --destination %s --jump DROP", testContext.CloudConfig.MasterName) iptablesRule := fmt.Sprintf("OUTPUT --destination %s --jump DROP", testContext.CloudConfig.MasterName)
defer func() { defer func() {
// This code will execute even if setting the iptables rule failed. // This code will execute even if setting the iptables rule failed.
@ -456,11 +458,13 @@ var _ = Describe("Nodes", func() {
} }
}) })
// TODO: this test has nothing to do with resizing nodes so it should be moved elsewhere. // TODO marekbiskup 2015-06-19 #10085
// TODO: two things are tested here: // This test has nothing to do with resizing nodes so it should be moved elsewhere.
// Two things are tested here:
// 1. pods from a uncontactable nodes are rescheduled // 1. pods from a uncontactable nodes are rescheduled
// 2. when a node joins the cluster, it can host new pods. // 2. when a node joins the cluster, it can host new pods.
// Factor out the cases into two separate tests. // Factor out the cases into two separate tests.
testName = "Uncontactable nodes, have their pods recreated by a replication controller, and can host new pods after rejoining." testName = "Uncontactable nodes, have their pods recreated by a replication controller, and can host new pods after rejoining."
It(testName, func() { It(testName, func() {
if testContext.CloudConfig.NumNodes < 2 { if testContext.CloudConfig.NumNodes < 2 {