From d9f99489ee01f6068e94e138eee0edba57f8fb49 Mon Sep 17 00:00:00 2001
From: guoyao <1015105054@qq.com>
Date: Wed, 10 Nov 2021 14:38:00 +0800
Subject: [PATCH] fix duplicate webhook insert operation

Signed-off-by: guoyao <1015105054@qq.com>
---
 pkg/apis/admissionregistration/validation/validation.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pkg/apis/admissionregistration/validation/validation.go b/pkg/apis/admissionregistration/validation/validation.go
index 0f887529878..aac50551a76 100644
--- a/pkg/apis/admissionregistration/validation/validation.go
+++ b/pkg/apis/admissionregistration/validation/validation.go
@@ -217,8 +217,9 @@ func validateValidatingWebhookConfiguration(e *admissionregistration.ValidatingW
 		if opts.requireUniqueWebhookNames && len(hook.Name) > 0 {
 			if hookNames.Has(hook.Name) {
 				allErrors = append(allErrors, field.Duplicate(field.NewPath("webhooks").Index(i).Child("name"), hook.Name))
+			} else {
+				hookNames.Insert(hook.Name)
 			}
-			hookNames.Insert(hook.Name)
 		}
 	}
 	return allErrors
@@ -248,8 +249,9 @@ func validateMutatingWebhookConfiguration(e *admissionregistration.MutatingWebho
 		if opts.requireUniqueWebhookNames && len(hook.Name) > 0 {
 			if hookNames.Has(hook.Name) {
 				allErrors = append(allErrors, field.Duplicate(field.NewPath("webhooks").Index(i).Child("name"), hook.Name))
+			} else {
+				hookNames.Insert(hook.Name)
 			}
-			hookNames.Insert(hook.Name)
 		}
 	}
 	return allErrors