github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-01 15:58:37 +00:00
Code Issues Projects Releases Wiki Activity

Reduce redundant Nodes().List() call

Browse Source 
dumpAllNodeInfo() called Nodes().List() internally, but the function
is called from DumpAllNamespaceInfo() only and DumpAllNamespaceInfo()
calls Nodes().List() before calling dumpAllNodeInfo().
So this makes the result of Nodes().List() being passed to
dumpAllNodeInfo() then reduce a call of Nodes().List().
This commit is contained in:
Kenichi Omichi 2019-08-28 23:08:44 +00:00
parent 02a2d79bde
commit da85510bd3
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/e2e/framework/util.go
View File

@ -1775,7 +1775,7 @@ func DumpAllNamespaceInfo(c clientset.Interface, namespace string) {
return return
} }
if len(nodes.Items) <= maxNodesForDump { if len(nodes.Items) <= maxNodesForDump {
dumpAllNodeInfo(c) dumpAllNodeInfo(c, nodes)
} else { } else {
e2elog.Logf("skipping dumping cluster info - cluster too large") e2elog.Logf("skipping dumping cluster info - cluster too large")
} }
@ -1794,13 +1794,7 @@ func (o byFirstTimestamp) Less(i, j int) bool {
return o[i].FirstTimestamp.Before(&o[j].FirstTimestamp) return o[i].FirstTimestamp.Before(&o[j].FirstTimestamp)
} }
func dumpAllNodeInfo(c clientset.Interface) { func dumpAllNodeInfo(c clientset.Interface, nodes *v1.NodeList) {
// It should be OK to list unschedulable Nodes here.
nodes, err := c.CoreV1().Nodes().List(metav1.ListOptions{})
if err != nil {
e2elog.Logf("unable to fetch node list: %v", err)
return
}
names := make([]string, len(nodes.Items)) names := make([]string, len(nodes.Items))
for ix := range nodes.Items { for ix := range nodes.Items {
names[ix] = nodes.Items[ix].Name names[ix] = nodes.Items[ix].Name